Skip to content
This repository was archived by the owner on Mar 11, 2020. It is now read-only.

Conversation

@mailgun
Copy link

@mailgun mailgun commented Jul 25, 2013

Hey Solomon!

I'm think the proto is in the pretty good shape now.

There are some quirks left, but I think it's a good start.

Here's what was done:

Parsing

Parser covered by tests + additional parameters validation

Replies

Reply generator with support of all Redis reply types +test coverage

Handler

I've restored the reflection based approach, but slightly changed it in the following way:

Handler

The base handler does not require any reflection, so anyone can write a low level handler if needed (like I need actually)

AutoHandler

The new AutoHandler supports reflection-based stuff as demonstrated in auto_test.go with some changes:

  • Signature checks are done when the handler is created, not in the run time
  • Variadic functions replaced with support for maps (see HMSET for reference)
  • Auto validation and support for integers, strings, bytes and nil replies

Additional Stuff

There's a couple of requests I got for you:

  • Can you please add the LICENSE, there's currenlty none, we need it
  • Can you add me as a collaborator on your repo, as I'd be actively working on it for my purposes.

Thanks,
Sasha

shykes pushed a commit that referenced this pull request Jul 29, 2013
Changes & Improvements
@shykes shykes merged commit d2e3487 into docker-archive:master Jul 29, 2013
tgrennan pushed a commit to platinasystems/go-redis-server that referenced this pull request Jun 16, 2016
Make Code public in the StatusReply
tgrennan pushed a commit to platinasystems/go-redis-server that referenced this pull request Jun 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants