This repository was archived by the owner on Mar 11, 2020. It is now read-only.
Changes & Improvements #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Solomon!
I'm think the proto is in the pretty good shape now.
There are some quirks left, but I think it's a good start.
Here's what was done:
Parsing
Parser covered by tests + additional parameters validation
Replies
Reply generator with support of all Redis reply types +test coverage
Handler
I've restored the reflection based approach, but slightly changed it in the following way:
Handler
The base handler does not require any reflection, so anyone can write a low level handler if needed (like I need actually)
AutoHandler
The new AutoHandler supports reflection-based stuff as demonstrated in auto_test.go with some changes:
Additional Stuff
There's a couple of requests I got for you:
Thanks,
Sasha