Override health check port with $PORT in check.sh#100
Merged
vfarcic merged 1 commit intodocker-flow:masterfrom Aug 9, 2019
Merged
Override health check port with $PORT in check.sh#100vfarcic merged 1 commit intodocker-flow:masterfrom
vfarcic merged 1 commit intodocker-flow:masterfrom
Conversation
The proxy server allows you to configure the port that it runs on with the environment variable `PORT`. If you do that, the health check will fail because 8080 is hard-coded and docker-flow-proxy will continually reload itself. This will use the port from `PORT` and fallback to 8080 if it's not found
Contributor
|
This looks like the correct fix. Although, it seems like the CI is not running here anymore. 😅 |
Contributor
|
Sorry for the delay. The images of the new release are now available. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The proxy server allows you to configure the port that it runs on with the environment variable
PORT. If you do that, the health check will fail because 8080 is hard-coded and docker-flow-proxy will continually reload itself. This will use the port fromPORTand fallback to 8080 if it's not found