Skip to content

Redirect unless https proto#68

Merged
thomasjpfan merged 4 commits intodocker-flow:masterfrom
audunhalland:redirectUnlessHttpsProto
Oct 9, 2018
Merged

Redirect unless https proto#68
thomasjpfan merged 4 commits intodocker-flow:masterfrom
audunhalland:redirectUnlessHttpsProto

Conversation

@audunhalland
Copy link
Copy Markdown
Contributor

@audunhalland audunhalland commented Sep 18, 2018

Implements the required change in order to fix #67 .

A new service query parameter redirectUnlessHttpsProto is added, enabling a previously (short-term) supported feature, that was since removed.

@audunhalland
Copy link
Copy Markdown
Contributor Author

Build failure, error message appears to be unrelated to my changes.

@thomasjpfan
Copy link
Copy Markdown
Contributor

Can you force the CI to run again with:

git commit --allow-empty -m "Trigger CI"

@audunhalland
Copy link
Copy Markdown
Contributor Author

@thomasjpfan build error looks related to sirupsen/logrus#824. Looks like some windows port thingy that I'm not familiar with and also I'm not a golang expert at all so I'm not sure how to fix it.

@dgsb
Copy link
Copy Markdown

dgsb commented Sep 25, 2018

@audunhalland this is indeed a new dependency which has been added in order to perform colored output on windows. To fix your build for windows target a simple go get should be enough to fix your build.

@audunhalland
Copy link
Copy Markdown
Contributor Author

After a bit of searching in the dark it seems to fail inside the cross-compile container vfarcic/gox. The entrypoint of that image is

#!/usr/bin/env bash

go get -d -v -t

gox --output="$1_{{.OS}}_{{.Arch}}" -osarch="linux/amd64 linux/arm windows/amd64 darwin/amd64"

Is there some conditional arch-based library selection going on so that it calling go get "outside" gox ... won't work?

@thomasjpfan
Copy link
Copy Markdown
Contributor

@audunhalland Thanks for looking into it. It seems go get seems to avoid getting windows dependencies when ran in a non-windows environment.

I have been considering moving this project to go modules to avoid build issue such as this. Fixing the build process is out of scope for this PR. I will fix the build process in another PR, so that this PR can proceed.

@thomasjpfan
Copy link
Copy Markdown
Contributor

@audunhalland Can you merge the master branch with this PR? This should fix the build issues.

@thomasjpfan thomasjpfan merged commit 68dceba into docker-flow:master Oct 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need for redirectUnlessHttpsProto

3 participants