Redirect unless https proto#68
Conversation
|
Build failure, error message appears to be unrelated to my changes. |
|
Can you force the CI to run again with: git commit --allow-empty -m "Trigger CI" |
|
@thomasjpfan build error looks related to sirupsen/logrus#824. Looks like some windows port thingy that I'm not familiar with and also I'm not a golang expert at all so I'm not sure how to fix it. |
|
@audunhalland this is indeed a new dependency which has been added in order to perform colored output on windows. To fix your build for windows target a simple go get should be enough to fix your build. |
|
After a bit of searching in the dark it seems to fail inside the cross-compile container Is there some conditional arch-based library selection going on so that it calling |
|
@audunhalland Thanks for looking into it. It seems I have been considering moving this project to go modules to avoid build issue such as this. Fixing the build process is out of scope for this PR. I will fix the build process in another PR, so that this PR can proceed. |
|
@audunhalland Can you merge the master branch with this PR? This should fix the build issues. |
Implements the required change in order to fix #67 .
A new service query parameter
redirectUnlessHttpsProtois added, enabling a previously (short-term) supported feature, that was since removed.