Skip to content

Conversation

@tianon
Copy link
Member

@tianon tianon commented Mar 6, 2024

My favorite thing about this is that only the uclibc variants actually change, which tells us that none of the files we take from buildroot in the other variants have changed (which has caused unexpected breakage in the past). 😄

@tianon tianon merged commit 2d996d5 into docker-library:master Mar 6, 2024
@tianon tianon deleted the buildroot-2024.02 branch March 6, 2024 21:08
@tianon
Copy link
Member Author

tianon commented Mar 6, 2024

Huh, arguably this should actually drop all the other architectures metadata for the builds that change, but it's hard to know which ones change and that delete/re-add would kill the "nice metadata history" property I'm going for by merging them to master in the first place. 🤔

@tianon
Copy link
Member Author

tianon commented Mar 6, 2024

I guess we really should probably do the double build so that we merge all the metadata back in and have all the arch-specific build commits point to a history that has all the metadata merged (and hope that we do them back-to-back enough that we still have hot build cache, or explicitly rebase them 😞).

@tianon
Copy link
Member Author

tianon commented Mar 6, 2024

For now, I think my stance is going to be that if you want accurate/consistent metadata for a specific architecture, you have to look at the build/"dist" branch for that architecture (or master, post-cherry-picks), as every other architecture's branch might / will likely have out-of-date metadata for other architectures. I think that's a fair constraint.

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Mar 6, 2024
Changes:

- docker-library/busybox@2d996d5: Merge pull request docker-library/busybox#192 from infosiftr/buildroot-2024.02
- docker-library/busybox@20bf190: Update buildroot to 2024.02
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Mar 7, 2024
Changes:

- docker-library/busybox@2d996d5: Merge pull request docker-library/busybox#192 from infosiftr/buildroot-2024.02
- docker-library/busybox@20bf190: Update buildroot to 2024.02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant