Adjust DOCKER_TLS_CERTDIR behavior to allow providing server certs without CA #402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thout CA This is the way to specify "I want TLS configured, but I'm managing the certs myself" The only thing we'll do is verify that the `cert.pem` is legit with respect to the `ca.pem` and then we'll let Docker itself provide any relevant errors beyond that.
yosifkit
approved these changes
Feb 9, 2023
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Feb 10, 2023
Changes: - docker-library/docker@9a3b24b: Update 23.0 to 23.0.1 - docker-library/docker@aba0ad9: Merge pull request docker-library/docker#402 from infosiftr/optional-tls-generation - docker-library/docker@6b3d48a: Adjust DOCKER_TLS_CERTDIR behavior to allow providing server certs without CA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the way to specify "I want TLS configured, but I'm managing the certs myself"
The only thing we'll do is verify that the
cert.pemis legit with respect to theca.pemand then we'll let Docker itself provide any relevant errors beyond that.Fixes #401