Swap "git" variant to be "dind"-based in 23+ #423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, `docker build git://...` would invoke `git` in the client context, but `buildx` does so in the daemon context instead, and given that it is the default in 23+, let's adjust the git-including variant to be dind-based to simplify this for users who desire the 50MiB+ increase this workflow requires.
yosifkit
approved these changes
Apr 25, 2023
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Apr 25, 2023
Changes: - docker-library/docker@2884d49: Merge pull request docker-library/docker#423 from infosiftr/git-dind - docker-library/docker@fcb9d85: Swap "git" variant to be "dind"-based in 23+
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Apr 26, 2023
Changes: - docker-library/docker@d49ab87: Update 23.0 to 23.0.5 - docker-library/docker@2884d49: Merge pull request docker-library/docker#423 from infosiftr/git-dind - docker-library/docker@fcb9d85: Swap "git" variant to be "dind"-based in 23+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically,
docker build git://...would invokegitin the client context, butbuildxdoes so in the daemon context instead, and given that it is the default in 23+, let's adjust the git-including variant to be dind-based to simplify this for users who desire the 50MiB+ increase this workflow requires.Fixes #422
Closes #295