Skip to content

Conversation

@patricklucas
Copy link
Contributor

Associated official-images PR: docker-library/official-images#2895

Closes #850

Copy link
Member

@yosifkit yosifkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple suggestions


Please report issues with this docker image on this [Github project](https://github.com/docker-flink/docker-flink).

For general questions about Flink, see the [Community & Project Info](https://flink.apache.org/community.html), in particular the Flink user mailing list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With #888 this file has become obsolete, but we have not documented what those changes mean for new images. 😞

I think for your case, you would instead need a get-help.md with the content of [Community & Project Info](https://flink.apache.org/community.html). It'll appear in the "Quick Reference" section under "Where to get help": like crate.

@@ -0,0 +1 @@
[the Docker Community](%%GITHUB-REPO%%)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you want this to reflect the same members of the Apache Flink community that you have at the end of the content? It'll appear in the "Quick Reference" section under "Maintained by", like debian.

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor notes -- depending on your thoughts to my question in moby/moby#33101 (comment), we can get this merged. 👍

@@ -0,0 +1 @@
Community & Project Info](https://flink.apache.org/community.html)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a [ missing at the beginning here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

flink/content.md Outdated
To use Flink, you can submit a job to the cluster using the Web UI or you can also do it from a different Flink container, for example:

```console
$ docker run -t flink flink run -m <jobmanager:port> -c <your_class> <your_jar> <your_params>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to add --rm to this one, since it's not long-running. 👍

@tianon
Copy link
Member

tianon commented May 9, 2017

Apparently copy-pasting links is hard -- docker-library/official-images#2895 (comment) is what I meant to link to. 😓

@patricklucas
Copy link
Contributor Author

Changes made. Thanks for the review. :)

@tianon tianon merged commit 8f48857 into docker-library:master May 9, 2017
@patricklucas patricklucas deleted the add_apache_flink branch May 10, 2017 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants