-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add Apache Flink #893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Apache Flink #893
Conversation
3386685 to
7554ca7
Compare
yosifkit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple suggestions
flink/user-feedback.md
Outdated
|
|
||
| Please report issues with this docker image on this [Github project](https://github.com/docker-flink/docker-flink). | ||
|
|
||
| For general questions about Flink, see the [Community & Project Info](https://flink.apache.org/community.html), in particular the Flink user mailing list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With #888 this file has become obsolete, but we have not documented what those changes mean for new images. 😞
I think for your case, you would instead need a get-help.md with the content of [Community & Project Info](https://flink.apache.org/community.html). It'll appear in the "Quick Reference" section under "Where to get help": like crate.
flink/maintainer.md
Outdated
| @@ -0,0 +1 @@ | |||
| [the Docker Community](%%GITHUB-REPO%%) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you want this to reflect the same members of the Apache Flink community that you have at the end of the content? It'll appear in the "Quick Reference" section under "Maintained by", like debian.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some minor notes -- depending on your thoughts to my question in moby/moby#33101 (comment), we can get this merged. 👍
flink/get-help.md
Outdated
| @@ -0,0 +1 @@ | |||
| Community & Project Info](https://flink.apache.org/community.html) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a [ missing at the beginning here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
flink/content.md
Outdated
| To use Flink, you can submit a job to the cluster using the Web UI or you can also do it from a different Flink container, for example: | ||
|
|
||
| ```console | ||
| $ docker run -t flink flink run -m <jobmanager:port> -c <your_class> <your_jar> <your_params> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be a good idea to add --rm to this one, since it's not long-running. 👍
|
Apparently copy-pasting links is hard -- docker-library/official-images#2895 (comment) is what I meant to link to. 😓 |
|
Changes made. Thanks for the review. :) |
Associated official-images PR: docker-library/official-images#2895
Closes #850