Move test from docker-library/official-images #384
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test isn't useful for "interoperability" like some of the language-specific tests, and is really very specific to this particular image (and we only use it as a tool to roughly validate that we've packaged the software correctly), so it makes more sense for it to live here.
acburdine
approved these changes
May 31, 2023
|
This should make it a lot easier to update when it has to change during bumps too 😂 |
|
Might be worth merging docker-library/official-images#14757 first so we can double check this actually works correctly (although I'm not worried). |
yosifkit
reviewed
Jun 2, 2023
| trap "docker rm -vf $mysqlCid > /dev/null" EXIT | ||
|
|
||
| # "Unknown database error" / "ECONNREFUSED" (and Ghost just crashing hard) | ||
| . "$dir/../../retry.sh" --tries 30 'docker exec -i -e MYSQL_PWD="$mysqlPassword" "$mysqlCid" mysql -h127.0.0.1 -u"$mysqlUser" --silent "$mysqlDatabase" <<<"SELECT 1"' |
There was a problem hiding this comment.
/home/runner/work/ghost/ghost/.test/tests/ghost-basics/run.sh: line 36: /home/runner/work/ghost/ghost/.test/tests/ghost-basics/../../retry.sh: No such file or directory 'ghost-basics' [4/4]...failed
🤔 what do we do about these "lib" scripts?
|
Gah, we also need to update the @docker-library-bot automation to look for this and run these tests as well (or finally do the hairy work to try and GitHub-Actions-ize those, which is ... a little complicated). |
|
Going to close for now. We need to redesign the test harness a bit to make this work (possibly consider moving to a "real" testing framework or something). |
This was referenced Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test isn't useful for "interoperability" like some of the language-specific tests, and is really very specific to this particular image (and we only use it as a tool to roughly validate that we've packaged the software correctly), so it makes more sense for it to live here.