-
Notifications
You must be signed in to change notification settings - Fork 525
Label images with base distro version #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…very image - this should make it easier for a us to move from one base image to the next while letting users see the breaking changes (jessie -> stretch, alpine3.5 -> alpine3.6)
Member
Author
|
Ordering is slightly different, but it's all there: # diff <(bashbrew cat golang) <(bashbrew cat <(./generate-stackbrew-library.sh))
diff --git a/dev/fd/63 b/dev/fd/62
--- a/dev/fd/63
+++ b/dev/fd/62
@@ -1,14 +1,14 @@
Maintainers: Tianon Gravi <admwiggin@gmail.com> (@tianon), Joseph Ferguson <yosifkit@gmail.com> (@yosifkit), Johan Euphrosine <proppy@google.com> (@proppy)
GitRepo: https://github.com/docker-library/golang.git
-Tags: 1.9beta2, 1.9-rc, 1.9, rc
+Tags: 1.9beta2-stretch, 1.9-rc-stretch, 1.9-stretch, rc-stretch, 1.9beta2, 1.9-rc, 1.9, rc
Architectures: amd64, arm32v7, arm64v8, i386, ppc64le, s390x
-GitCommit: cc59d934fca2e3a7dd8ebcd0eee82f34589f3bd3
-Directory: 1.9-rc
+GitCommit: 2a15dfff04accfd31c2a45b3bb7423aa86aa2d60
+Directory: 1.9-rc/stretch
-Tags: 1.9beta2-alpine, 1.9-rc-alpine, 1.9-alpine, rc-alpine
-GitCommit: cc59d934fca2e3a7dd8ebcd0eee82f34589f3bd3
-Directory: 1.9-rc/alpine
+Tags: 1.9beta2-alpine3.6, 1.9-rc-alpine3.6, 1.9-alpine3.6, rc-alpine3.6, 1.9beta2-alpine, 1.9-rc-alpine, 1.9-alpine, rc-alpine
+GitCommit: 2a15dfff04accfd31c2a45b3bb7423aa86aa2d60
+Directory: 1.9-rc/alpine3.6
Tags: 1.9beta2-windowsservercore, 1.9-rc-windowsservercore, 1.9-windowsservercore, rc-windowsservercore
Architectures: windows-amd64
@@ -22,29 +22,29 @@ GitCommit: cc59d934fca2e3a7dd8ebcd0eee82f34589f3bd3
Directory: 1.9-rc/windows/nanoserver
Constraints: nanoserver
-Tags: 1.8.3, 1.8, 1, latest
-Architectures: amd64, arm32v7, i386, ppc64le, s390x
-GitCommit: 97b2ff201ec59b9a037197d132c64eb937370c64
-Directory: 1.8
-
-Tags: 1.8.3-onbuild, 1.8-onbuild, 1-onbuild, onbuild
-Architectures: amd64, arm32v7, i386, ppc64le, s390x
-GitCommit: 132cd70768e3bc269902e4c7b579203f66dc9f64
-Directory: 1.8/onbuild
-
Tags: 1.8.3-stretch, 1.8-stretch, 1-stretch, stretch
Architectures: amd64, arm32v7, i386, ppc64le, s390x
GitCommit: 97b2ff201ec59b9a037197d132c64eb937370c64
Directory: 1.8/stretch
-Tags: 1.8.3-alpine, 1.8-alpine, 1-alpine, alpine
-GitCommit: 64b88dc3e9d83e71eafc000fed1f0d5e289b3e65
-Directory: 1.8/alpine
+Tags: 1.8.3-jessie, 1.8-jessie, 1-jessie, jessie, 1.8.3, 1.8, 1, latest
+Architectures: amd64, arm32v7, i386, ppc64le, s390x
+GitCommit: 2a15dfff04accfd31c2a45b3bb7423aa86aa2d60
+Directory: 1.8/jessie
Tags: 1.8.3-alpine3.6, 1.8-alpine3.6, 1-alpine3.6, alpine3.6
GitCommit: 495a742832974d434c6e3356e19c93b0e82543c8
Directory: 1.8/alpine3.6
+Tags: 1.8.3-alpine3.5, 1.8-alpine3.5, 1-alpine3.5, alpine3.5, 1.8.3-alpine, 1.8-alpine, 1-alpine, alpine
+GitCommit: 2a15dfff04accfd31c2a45b3bb7423aa86aa2d60
+Directory: 1.8/alpine3.5
+
+Tags: 1.8.3-onbuild, 1.8-onbuild, 1-onbuild, onbuild
+Architectures: amd64, arm32v7, i386, ppc64le, s390x
+GitCommit: 132cd70768e3bc269902e4c7b579203f66dc9f64
+Directory: 1.8/onbuild
+
Tags: 1.8.3-windowsservercore, 1.8-windowsservercore, 1-windowsservercore, windowsservercore
Architectures: windows-amd64
GitCommit: 64b88dc3e9d83e71eafc000fed1f0d5e289b3e65
@@ -57,25 +57,16 @@ GitCommit: 64b88dc3e9d83e71eafc000fed1f0d5e289b3e65
Directory: 1.8/windows/nanoserver
Constraints: nanoserver
-Tags: 1.7.6, 1.7
-Architectures: amd64, arm32v7, i386, ppc64le, s390x
-GitCommit: 97b2ff201ec59b9a037197d132c64eb937370c64
-Directory: 1.7
-
-Tags: 1.7.6-onbuild, 1.7-onbuild
+Tags: 1.7.6-jessie, 1.7-jessie, 1.7.6, 1.7
Architectures: amd64, arm32v7, i386, ppc64le, s390x
-GitCommit: 2372c8cafe9cc958bade33ad0b8b54de8869c21f
-Directory: 1.7/onbuild
+GitCommit: 2a15dfff04accfd31c2a45b3bb7423aa86aa2d60
+Directory: 1.7/jessie
Tags: 1.7.6-wheezy, 1.7-wheezy
Architectures: amd64, arm32v7, i386
GitCommit: 97b2ff201ec59b9a037197d132c64eb937370c64
Directory: 1.7/wheezy
-Tags: 1.7.6-alpine, 1.7-alpine
-GitCommit: 9e519a8844c25e38fe67547e8f681ada486e473b
-Directory: 1.7/alpine
-
Tags: 1.7.6-alpine3.6, 1.7-alpine3.6
GitCommit: 495a742832974d434c6e3356e19c93b0e82543c8
Directory: 1.7/alpine3.6
@@ -84,6 +75,15 @@ Tags: 1.7.6-alpine3.5, 1.7-alpine3.5
GitCommit: 9e519a8844c25e38fe67547e8f681ada486e473b
Directory: 1.7/alpine3.5
+Tags: 1.7.6-alpine3.4, 1.7-alpine3.4, 1.7.6-alpine, 1.7-alpine
+GitCommit: 2a15dfff04accfd31c2a45b3bb7423aa86aa2d60
+Directory: 1.7/alpine3.4
+
+Tags: 1.7.6-onbuild, 1.7-onbuild
+Architectures: amd64, arm32v7, i386, ppc64le, s390x
+GitCommit: 2372c8cafe9cc958bade33ad0b8b54de8869c21f
+Directory: 1.7/onbuild
+
Tags: 1.7.6-windowsservercore, 1.7-windowsservercore
Architectures: windows-amd64
GitCommit: 9e519a8844c25e38fe67547e8f681ada486e473b |
tianon
approved these changes
Jul 11, 2017
Member
tianon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked over the full diff several times and the full output several times and can't see anything obviously wrong! 👍 ❤️
Member
|
(Not sure why AppVeyor is having a sad 🤷♂️) |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Jul 11, 2017
This was referenced Jul 11, 2017
Closed
krmcbride
added a commit
to krmcbride/dockerfiles
that referenced
this pull request
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier for a us to move the default from one base image to the next while letting users see the breaking changes (jessie -> stretch, alpine3.5 -> alpine3.6)