Support starting with encrypt-tmp-files #340
Conversation
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
In general this seems fine, thank you!
I have some suggestions since we have this same list of arguments embedded in several places now and it keeps getting more complex, I think we should probably extract that list of arguments out so we can define the "why" we have each one in a single place (and just a link is probably enough); see suggested changes.
We'll also need to update this in all the subdirectories so the CI will actually test it ("easiest" way is probably running ./update.sh).
(Also, happy to take over and make these changes directly if you'd prefer!)
|
Thanks!
Yes, it's probably easier for both of us, if you take it from here. |
Add `--encrypt-tmp-files=0` to `mysqld --verbose --help` to support starting up when `--encrypt-tmp-files=1` is set
Changes: - MariaDB/mariadb-docker@a6e2d7d: Merge pull request MariaDB/mariadb-docker#340 from darioseidl/patch-1 - MariaDB/mariadb-docker@0d197a9: Support starting with encrypt-tmp-files
Changes: - MariaDB/mariadb-docker@f0e04a7: Update to 1:10.2.37+maria~bionic - MariaDB/mariadb-docker@ac4469c: Update to 1:10.3.28+maria~focal - MariaDB/mariadb-docker@5d57b11: Update to 1:10.5.9+maria~focal - MariaDB/mariadb-docker@74078d3: Update to 1:10.4.18+maria~focal - MariaDB/mariadb-docker@a6e2d7d: Merge pull request MariaDB/mariadb-docker#340 from darioseidl/patch-1 - MariaDB/mariadb-docker@0d197a9: Support starting with encrypt-tmp-files
3 participants
Pull request for #339: Add
--encrypt-tmp-files=0tomysqld --verbose --helpto support starting up when--encrypt-tmp-files=1is set.