Skip to content

Conversation

@tianon
Copy link
Member

@tianon tianon commented Feb 16, 2021

Given these are duplicated (or should be -- as seen in the diff we already messed this up!) it makes sense to make them share a common variable.

This is ported from the changes I've proposed in MariaDB/mariadb-docker#340 (where MariaDB needs an additional parameter).

Given these are duplicated (or should be -- as seen in the diff we already messed this up!) it makes sense to make them share a common variable.
@yosifkit
Copy link
Member

For my (future) reference on why --encrypt-tmp-files from MariaDB/mariadb-docker#340 was not added here; the flag is not available in MySQL.

$ docker run -it --rm mysql:5.6 --verbose --help | grep encrypt
  --block-encryption-mode=name 
  --des-key-file=name Load keys for des_encrypt() and des_encrypt from given
block-encryption-mode                                      aes-128-ecb
$ docker run -it --rm mysql:5.7 --verbose --help | grep encrypt
  --block-encryption-mode=name 
  --des-key-file=name Load keys for des_encrypt() and des_encrypt from given
block-encryption-mode                                        aes-128-ecb
$ docker run -it --rm mysql:8.0 --verbose --help | grep encrypt
  --binlog-encryption Enable/disable binary and relay logs encryption.
  --binlog-rotate-encryption-master-key-at-startup 
                      Force binlog encryption master key rotation at startup
  --block-encryption-mode=name 
  --default-table-encryption 
                      encryption property unless the user specifies an explicit
                      encryption property.
  --innodb-redo-log-encrypt 
  --innodb-undo-log-encrypt 
  --table-encryption-privilege-check 
binlog-encryption                                            FALSE
binlog-rotate-encryption-master-key-at-startup               FALSE
block-encryption-mode                                        aes-128-ecb
default-table-encryption                                     FALSE
innodb-redo-log-encrypt                                      FALSE
innodb-undo-log-encrypt                                      FALSE
table-encryption-privilege-check                             FALSE

@yosifkit yosifkit merged commit d9fecf6 into docker-library:master Feb 16, 2021
@yosifkit yosifkit deleted the verbose-help-args branch February 16, 2021 20:36
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Feb 16, 2021
Changes:

- docker-library/mysql@d9fecf6: Merge pull request docker-library/mysql#741 from infosiftr/verbose-help-args
- docker-library/mysql@2966bfb: Add consistent variable for "--verbose --help" arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants