Execute SQL in entrypoint with "--comments" #728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The primary reason to disable this seems to be to avoid normally-unnecessary data transfer, but in this case we're explicitly connecting over the local unix socket, so streaming the comments to the server and letting it strip them should be *almost* as efficient as the client doing so.
Member
|
Rebased, updated the template copy also, and added this note to the commit message:
|
Member
|
Thank you for the contribution (and your patience)! ❤️ |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Dec 19, 2020
Changes: - docker-library/mysql@1612c57: Merge pull request docker-library/mysql#728 from marc-mabe/patch-1 - docker-library/mysql@b0a0e54: Execute SQL in entrypoint with "--comments"
|
For reference, this does not work as intended for MySQL 5.7.41 and we had to remove it by using RUN sed -i 's/--comments //' /usr/local/bin/docker-entrypoint.sh in our Dockerfile. The issue was the comment at the top of the file made the import of the MySQL dump crash. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to prevent lost of SQL comments in triggers, procedures etc. on initdb.
fixes #718