Set sysconfdir explicitly during build
#1636
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to completely remove the `php-fpm.conf` hacks by having PHP do the right thing by default instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to completely remove the
php-fpm.confhacks by having PHP do the right thing by default instead.There's a lot of overlap here with #1635, which is not incidental -- reviewing that had me scratching my head and feeling sad at my past self. 😂
So I think that one should probably merge first and then I'll rebase this, but like I said over there, I think this one should wait until the new year too just in case it has some unintended side effect I'm not seeing right now. 🙈