Refactor Dockerfile, switching the base from buildpack-deps over to debian directly#36
Merged
tianon merged 1 commit intodocker-library:masterfrom Nov 7, 2014
infosiftr:slim-build
Merged
Refactor Dockerfile, switching the base from buildpack-deps over to debian directly#36tianon merged 1 commit intodocker-library:masterfrom infosiftr:slim-build
buildpack-deps over to debian directly#36tianon merged 1 commit intodocker-library:masterfrom
infosiftr:slim-build
Conversation
… `debian` directly This results in a dramatic reduction of image size: ```console $ docker images php REPOSITORY TAG IMAGE ID CREATED VIRTUAL SIZE php 5.4 6b03f428509e 3 hours ago 354.3 MB php 5.4-apache 2bd126f2c469 2 minutes ago 394.8 MB php 5.5 19a5113df69a 9 minutes ago 356.4 MB php 5.5-apache 6c892721307f 2 minutes ago 396.9 MB php 5.6 69aead156fe7 10 minutes ago 356.8 MB php 5.6-apache 2d0bae628aaf About an hour ago 397.3 MB ``` vs the old: ```console $ docker images php REPOSITORY TAG IMAGE ID CREATED VIRTUAL SIZE php 5.4 e760b9bd2c6c 2 days ago 736.9 MB php 5.4-apache 62c23e8f1704 2 days ago 811.8 MB php 5.5 156d2a323bc0 2 days ago 739.8 MB php 5.5-apache 3014d0f81b29 2 days ago 814.7 MB php 5.6 dab86418397c 2 days ago 740.2 MB php 5.6-apache b3c4a0633954 2 days ago 815.1 MB ```
Contributor
|
LGTM! ❤️ |
Member
Author
|
This also refactors the way we handle autogenerated bits, the reasons for which will be more apparent in my next PR (but the interface here is generally cleaner and easier to understand). 😈 I also realized we weren't stripping binaries, so that got us another 9-12MB savings. 👍 |
tianon
added a commit
that referenced
this pull request
Nov 7, 2014
Refactor Dockerfile, switching the base from `buildpack-deps` over to `debian` directly
Contributor
|
Yay! |
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Nov 7, 2014
- `node`: NPM 2.1.7 - `php`: cut image sizes roughly in half across the board (docker-library/php#36) - `redis`: drop official support for versions upstream doesn't support (redis/docker-library-redis#15) - `wordpress`: fix `chown` issue (docker-library/wordpress#21)
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Nov 7, 2014
- `node`: NPM 2.1.7 - `php`: cut image sizes roughly in half across the board (docker-library/php#36) - `redis`: drop official support for versions upstream doesn't support (redis/docker-library-redis#15) - `wordpress`: fix `chown` issue (docker-library/wordpress#21)
|
Nice 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This results in a dramatic reduction of image size:
vs the old:
Fixes #33