Built php with external sqlite #884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zerkms
force-pushed
the
feature/SQLITE_RTREE
branch
from
94a0a90 to
38784bb
Compare
tianon
force-pushed
the
feature/SQLITE_RTREE
branch
from
38784bb to
3a54676
Compare
|
Oh, I hadn't noticed that 7.4+ removed the bundled sqlite entirely! 🎉 I've updated this to add a reference to the exact upstream commit that removes the bundled sqlite (php/php-src@6083a38) so it's more clear why we're breaking from our normal of trusting PHP's bundled libraries. 👍 |
|
Thanks! |
tianon
pushed a commit
to docker-library/official-images
that referenced
this pull request
Oct 4, 2019
Changes: - docker-library/php@5aea77c: Update to 7.4.0RC3 - docker-library/php@e568fc2: Merge pull request docker-library/php#884 from zerkms/feature/SQLITE_RTREE - docker-library/php@3a54676: Always build with external sqlite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It addresses #731 and my own issue: for not having the RTree extension built-in
I have found a way to build an extension externally and load it using a recipe like https://gist.github.com/zerkms/916cbe1a7714b4feead487dfb8e1e97d
But there are problems with it: it's error prone - the version of sqlite3 should be kept in sync with php, otherwise subtle bugs may occur. Also, it requires dynamic feature detection, which makes applications more complicated.
Given 7.4 switched to the external sqlite3, and given that the sqlite3 dev package is available inside the image nevertheless - what do you think about having all the versions built against the external sqlite3 library?
Thanks.
Fixes #731