Move end of line comments to their own line to improve readability #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianon
reviewed
Apr 22, 2019
tianon
approved these changes
Apr 22, 2019
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Apr 23, 2019
Changes: - docker-library/postgres@e521526: Remove "backwards compatibility" entrypoint symlink in 12+ - docker-library/postgres@03db72f: Remove UUID variability now that 9.3 is gone (per comment in "update.sh") - docker-library/postgres@59e5a64: Merge pull request docker-library/postgres#568 from infosiftr/pr-309 - docker-library/postgres@85aadc0: Move end of line comment to its own line to improve readability
|
But this triggers a warning on docker build, which says that empty continuation lines will be an error in a future release. Has that future been saved yet? |
Member
Author
|
That was fixed in moby/moby#35004 |
Member
|
That was a bug in a particular version of Docker that should've now been long-since fixed where this was detected incorrectly as an empty continuation line. 👍 See moby/moby#35004 for the PR which fixed this (Docker 17.10+). |
|
But it seems like we use the default docker version on Travis CI, which is really old. So that error is shown. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces and closes #309 (sorry for the delay 🙇♂️)