Fix new zstd support for alpine images #944
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In e8ebf74 zstd was installed as build dependency and thus does not end up in the final image which in turn renders docker-entrypoint.sh broken when using *.sql.zst files.
tianon
reviewed
Mar 28, 2022
Comment on lines
133
to
134
| # tzdata is optional, but only adds around 1Mb to image size and is recommended by Django documentation: | ||
| # https://docs.djangoproject.com/en/1.10/ref/databases/#optimizing-postgresql-s-configuration |
Member
There was a problem hiding this comment.
I guess we can probably remove this comment now too. 😅
Edit: e483778 👍
tianon
approved these changes
Mar 28, 2022
Member
|
Thanks! |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Mar 28, 2022
Changes: - docker-library/postgres@e483778: Remove unnecessary comment - docker-library/postgres@6335be0: Merge pull request docker-library/postgres#944 from zappolowski/fix-zstd-for-alpine - docker-library/postgres@b4604f5: Fix new zstd support for alpine images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In e8ebf74 zstd was installed as build dependency and thus does not end up in the final image which in turn renders docker-entrypoint.sh broken when using *.sql.zst files.