Use more defensive LDFLAGS append method
#1107
Merged
+62
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Verified locally by building with Additionally, a basic test that
|
Merged
yosifkit
approved these changes
Jan 20, 2026
In Debian Trixie and older, `dpkg-buildflags --get LDFLAGS` returns something like `-Wl,-z-relro` and in Forky and newer it looks like `-Wl,-z-relro -fcf-protection`, so instead of relying on that `-Wl` and appending to the existing value, we can (and should) just add new `-Wl` values to the end, which _should_ be combined together correctly by the compiler/linker.
Member
Author
|
Hah, I created a conflict by merging #1108 first 😂 |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Jan 20, 2026
Changes: - docker-library/python@850e1ea3: Merge pull request docker-library/python#1107 from infosiftr/LDFLAGS - docker-library/python@90e9ca41: Use more defensive `LDFLAGS` append method - docker-library/python@12629ffd: Merge pull request docker-library/python#1108 from infosiftr/indentation - docker-library/python@37025e2a: Fix indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Debian Trixie and older,
dpkg-buildflags --get LDFLAGSreturns something like-Wl,-z-relroand in Forky and newer it looks like-Wl,-z-relro -fcf-protection, so instead of relying on that-Wland appending to the existing value, we can (and should) just add new-Wlvalues to the end, which should be combined together correctly by the compiler/linker.