Skip to content

Conversation

@tianon
Copy link
Member

@tianon tianon commented Mar 22, 2021

... to protect against WP-CLI loading it twice

Fixes #588

... to protect against WP-CLI loading it twice
@tianon
Copy link
Member Author

tianon commented Mar 22, 2021

@GoldenMickey any way you could help us test this fix? 🙏

@GoldenMickey
Copy link

Sorry for the late response. How can I test it ? Does modifying the "FROM" clause of the dockerfile is enough ?

@tianon
Copy link
Member Author

tianon commented Mar 30, 2021

I guess if you've got a local install that's affected, you can download the wp-config-docker.php file from this PR and embed it in your volume as wp-config.php which should allow you to test whether WP-CLI still throws the warning/error, but if you're doing this through some automated process you can build an image directly from this PR with something like docker build --pull --tag 'wordpress:php7.4-fpm-alpine' 'https://github.com/docker-library/wordpress.git#pull/590/merge:latest/php7.4/fpm-alpine'

@GoldenMickey
Copy link

GoldenMickey commented Apr 11, 2021

Fixed it for me after updating with wp-config-docker.php. Thank you!

@yosifkit yosifkit merged commit 0e92d89 into docker-library:master Apr 12, 2021
@yosifkit yosifkit deleted the function_exists branch April 12, 2021 16:53
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Apr 12, 2021
Changes:

- docker-library/wordpress@0e92d89: Merge pull request docker-library/wordpress#590 from infosiftr/function_exists
- docker-library/wordpress@5f1aba1: Remove more stuff that shouldn't exist
- docker-library/wordpress@e646d85: Remove accidental directories 😇
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fatal error: getenv_docker redeclare with wordpress+wpcli compose setup

3 participants