chore: remove default for sensitive values#169
Merged
cfis merged 1 commit intodocker-mailserver:masterfrom Jun 9, 2025
Merged
Conversation
Collaborator
|
Sorry I missed this PR. Agreed on a schema approach - would happily take PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those values provide a default that cannot be overwritten with a secret, because they're added twice to the container. Commenting them out by default removes the empty string default in order to allow us to pass it from a secret. This also keeps it backwards compatible for people that want to keep the secret inline as well.
Edit: generally creating a values schema approach would be the best bet and removing any non-mandatory values from the defaults.