Arm64 and check Compose v2 support#177
Conversation
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
mat007
left a comment
mat007
left a comment
There was a problem hiding this comment.
Awesome (pun intended), thanks!
|
Cool. Which of this changes it relevant for docker compose v2 support? At the first look, it seems they are all unrelated to this topic. |
|
@waja right, there is no specific change for Compose V2, the intent of this PR was to make sure all the samples work for |
glours
changed the title
| db: | ||
| image: mysql:8.0.19 | ||
| # We use a mariadb image which support both amd64 & arm64 architecture | ||
| image: mariadb:10.6.4-focal |
There was a problem hiding this comment.
Should we add the DB healthcheck to improve a bit ? A few samples have it already 😁
There was a problem hiding this comment.
I prefer to have a dedicated PR for DB healthcheck, I saw some errors when testing the samples and I think that it'll be better to spend some time completely focus on the healthcheck
| - db | ||
| db: | ||
| image: mysql:8.0.19 | ||
| # We use a mariadb image which support both amd64 & arm64 architecture |
There was a problem hiding this comment.
Typo support -> supports (and everywhere else this comment was added).
| db: | ||
| image: mysql:8.0.19 | ||
| # We use a mariadb image which support both amd64 & arm64 architecture | ||
| image: mariadb:10.6.4-focal |
| db: | ||
| image: mysql:8.0.19 | ||
| # We use a mariadb image which support both amd64 & arm64 architecture | ||
| image: mariadb:10.6.4-focal |
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
|
Hi all, ERROR: In file './docker-compose.yml', service 'restart' must be a mapping not a string. I tried: |
|
Hello @maxdehaas |
5 participants
Update samples to work in the same way from an
amd64or anarm64architecture and with Compose V2