react-java-mysql: use create-react-app for frontend#24
Merged
glours merged 1 commit intodocker:masterfrom Mar 24, 2020
jdrouet:update-react-apps
Merged
react-java-mysql: use create-react-app for frontend#24glours merged 1 commit intodocker:masterfrom jdrouet:update-react-apps
glours merged 1 commit intodocker:masterfrom
jdrouet:update-react-apps
Conversation
jdrouet
commented
Mar 23, 2020
| import logo from "./logo.svg"; | ||
| import "./App.css"; | ||
|
|
||
| type Greeting = { |
Contributor
Author
There was a problem hiding this comment.
Here is the data type returned by the backend
glours
requested changes
Mar 23, 2020
Collaborator
glours
left a comment
glours
left a comment
There was a problem hiding this comment.
Can you update the port in the Compose file and in the README, we choose to keep the default port used by the language/framework to be close as possible to the dev workflow
otherwise LGTM
Signed-off-by: Jérémie Drouet <jeremie.drouet@gmail.com>
glours
requested changes
Mar 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create the frontend with
create-react-appandtypescript(for java devs), and connect the proxy by settingsrc/setupProxy.js.Also merge the 2 dockerfiles into a single one.
The exposed port in dev mode is now 3000.
Signed-off-by: Jérémie Drouet jeremie.drouet@gmail.com