Skip to content

add configuration to use traefik-golang sample with Docker Dev Environments feature#254

Merged
glours merged 2 commits intodocker:masterfrom
glours:traefik-golang-dev-envs
Jul 12, 2022
Merged

add configuration to use traefik-golang sample with Docker Dev Environments feature#254
glours merged 2 commits intodocker:masterfrom
glours:traefik-golang-dev-envs

Conversation

@glours
Copy link
Collaborator

@glours glours commented Jun 30, 2022

  • Add a dedicated Compose file in the .docker directory for Dev Env configuration
  • Add a new dev-envs stage in the backend Dockerfile
  • Update documentation
  • small changes to compose.yaml

Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@glours glours requested a review from a team July 4, 2022 08:11
@glours glours force-pushed the traefik-golang-dev-envs branch from c8f4487 to 15a77c9 Compare July 4, 2022 08:12
glours and others added 2 commits July 5, 2022 14:54
…nments feature

Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
Co-authored-by: Milas Bowman <milasb@gmail.com>
Signed-off-by: Guillaume Lours <guillaume.lours@docker.com>
@glours glours force-pushed the traefik-golang-dev-envs branch from 15a77c9 to 3f0b5a9 Compare July 5, 2022 12:55
@glours glours requested a review from milas July 5, 2022 12:55
@milas milas added this to the Dev Envs Support milestone Jul 5, 2022
@glours glours self-assigned this Jul 5, 2022
Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@glours glours merged commit 6ac068d into docker:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants