Skip to content

Add flask sample#34

Merged
glours merged 2 commits intodocker:masterfrom
kouul:master
Mar 26, 2020
Merged

Add flask sample#34
glours merged 2 commits intodocker:masterfrom
kouul:master

Conversation

@kouul
Copy link
Contributor

@kouul kouul commented Mar 26, 2020

No description provided.

Signed-off-by: kouul <maulloohans@gmail.com>
@glours
Copy link
Collaborator

glours commented Mar 26, 2020

Hello @kouul,

Thanks for your PR!
We already have 2 samples with flask, one with nginx and mongo and an another one with nginx and mysql
Maybe we just need to improve the existing ones if needed, what do you think?

@kouul
Copy link
Contributor Author

kouul commented Mar 26, 2020

Hi @glours

Yes, but there is no sample of a plain flask application. By plain I mean without any connection to any db. It could be easier for someone to use this one to connect to another db other than Mysql or mongo.

@aiordache
Copy link
Contributor

Thank you @kouul
It sounds good to me to have more single service samples, we added some already. If I would like to run a simple python service, this may be useful as I wouldn't need to cleanup the other samples just to get my flask one.

Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add your sample in the main README.md, please?

Signed-off-by: kouul <maulloohans@gmail.com>
Copy link
Collaborator

@glours glours left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution @kouul 🙏

@glours glours merged commit 3003895 into docker:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants