Sample for apache-php7#42
Merged
glours merged 7 commits intodocker:masterfrom Apr 6, 2020
kouul:master
Merged
Conversation
Closed
glours
requested changes
Apr 6, 2020
apache-php/README.md
Outdated
| web: | ||
| build: app | ||
| ports: | ||
| - '8008:80' |
Collaborator
There was a problem hiding this comment.
Can we keep the default port of Apache?
apache-php/docker-compose.yaml
Outdated
| web: | ||
| build: app | ||
| ports: | ||
| - '8008:80' |
Collaborator
There was a problem hiding this comment.
Can we keep the default port of Apache?
apache-php/docker-compose.yaml
Outdated
| - '8008:80' | ||
| volumes: | ||
| - ./app:/var/www/html/ | ||
|
No newline at end of file |
Collaborator
There was a problem hiding this comment.
nit: add a new line at the end of the file
Signed-off-by: kouul <maulloohans@gmail.com>
Signed-off-by: kouul <maulloohans@gmail.com>
Signed-off-by: kouul <maulloohans@gmail.com>
Signed-off-by: kouul <maulloohans@gmail.com>
Signed-off-by: kouul <maulloohans@gmail.com>
Signed-off-by: kouul <maulloohans@gmail.com>
glours
requested changes
Apr 6, 2020
apache-php/README.md
Outdated
| ``` | ||
| $ docker ps | ||
| CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES | ||
| 2bc8271fee81 php-docker_web "docker-php-entrypoi…" About a minute ago Up About a minute 0.0.0.0:8008->80/tc php-docker_web_1 |
Collaborator
There was a problem hiding this comment.
You forgot to update the port in the docker ps description ;-)
apache-php/README.md
Outdated
| 2bc8271fee81 php-docker_web "docker-php-entrypoi…" About a minute ago Up About a minute 0.0.0.0:8008->80/tc php-docker_web_1 | ||
| ``` | ||
|
|
||
| After the application starts, navigate to `http://localhost:8008` in your web browser or run: |
apache-php/README.md
Outdated
|
|
||
| After the application starts, navigate to `http://localhost:8008` in your web browser or run: | ||
| ``` | ||
| $ curl localhost:8008 |
Contributor
Author
There was a problem hiding this comment.
Oops my bad.. its fixed 👍
Signed-off-by: kouul <maulloohans@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.