Merged
Conversation
gtardif
force-pushed
the
minecraft_sample
branch
from
50b6aa9 to
32b27ea
Compare
glours
requested changes
Aug 10, 2020
Collaborator
|
And add your sample in the main README |
gtardif
force-pushed
the
minecraft_sample
branch
from
32b27ea to
c0867ed
Compare
glours
requested changes
Aug 11, 2020
Collaborator
glours
left a comment
glours
left a comment
There was a problem hiding this comment.
Just few changes to merge the PR
| minecraft_1 | [15:06:39] [Server thread/INFO]: Thread RCON Listener started | ||
| minecraft_1 | [15:06:39] [RCON Listener #1/INFO]: RCON running on 0.0.0.0:25575 | ||
| ``` | ||
|
|
Collaborator
There was a problem hiding this comment.
Add the following section.
I can't manage to correctly add code section inside the github suggestion section ¯\(ツ)/¯
So the $ docker ps ... should be in code section 😅
Check containers are running and the port mapping:
$ docker ps CONTAINER ID IMAGE COMMAND CREATED STATUS PORTS NAMES 7f696c2fb101 itzg/minecraft-server "/start" 5 minutes ago Up 5 minutes (healthy) 0.0.0.0:25565->25565/tcp, 25575/tcp minecraft_minecraft_1
| ``` | ||
|
|
||
| Once it is initialized, run your Minecraft application, hit "Play", then "Multiplayer" and "Add server". Specify your new server IP : localhost:25565. You can then start playing. | ||
|
|
Collaborator
There was a problem hiding this comment.
Can you add screenshot of server configuration in the Minecraft 🤗?
glours
reviewed
Aug 11, 2020
minecraft/README.md
Outdated
Comment on lines
+57
to
+76
| ## Stop and remove the containers | ||
| ``` | ||
| $ docker-compose down | ||
| ``` |
Collaborator
There was a problem hiding this comment.
Can you replace with this ?
Stop and remove the containers
$ docker-compose downTo delete all data, remove all named volumes by passing the
-varguments:$ docker-compose down -v
gtardif
force-pushed
the
minecraft_sample
branch
from
c0867ed to
e42ad40
Compare
Signed-off-by: Guillaume Tardif <guillaume.tardif@docker.com>
gtardif
force-pushed
the
minecraft_sample
branch
from
e42ad40 to
8c2e3a6
Compare
glours
approved these changes
Aug 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.