Skip to content

fix typo#443

Merged
crazy-max merged 1 commit intodocker:masterfrom
alextes:patch-1
Sep 2, 2021
Merged

fix typo#443
crazy-max merged 1 commit intodocker:masterfrom
alextes:patch-1

Conversation

@alextes
Copy link
Copy Markdown
Contributor

@alextes alextes commented Aug 24, 2021

No description provided.

@alextes alextes requested a review from crazy-max as a code owner August 24, 2021 18:11
@crazy-max
Copy link
Copy Markdown
Member

@alextes Missing DCO

Signed-off-by: Alexander Tesfamichael <alex.tesfamichael@gmail.com>
@alextes
Copy link
Copy Markdown
Contributor Author

alextes commented Aug 31, 2021

@crazy-max nothing against you personally max but I find this quite silly. For a moment I considered whether going through the hassle of cloning (I used the web UI for this), rewriting a commit, force pushing, and pinging you here was worth the effort for what is a simple typo fix.

After reading about DCO for a couple of minutes I'm also far from convinced it contributes anything. Even if I sign off, that doesn't mean the code I contribute is actually code you can use and I'm no lawyer but I'd be surprised if "but he said it was code we could use so we're absolved of any responsibility" is a valid legal defense. This sounds a lot like legal trying to be useful but instead of asking "how can we enable you", be busy with "how can we look useful protecting us". Did docker ever get sued for code they used and then pay damages that would've been prevented with a DCO?? Hiiiiighly doubt it.

Anyway, rant over, doubt you have anything to do with it @crazy-max 😂 , have a nice day, but who knows someday someone up the chain might ask you about how to get more contributions to come in and you can forward this :p

Love the action btw! Thanks!

@crazy-max crazy-max merged commit 821890e into docker:master Sep 2, 2021
@alextes alextes deleted the patch-1 branch September 2, 2021 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants