commands/history: rewrite with stdlib multi-errors#3626
Merged
crazy-max merged 1 commit intodocker:masterfrom Jan 27, 2026
Merged
commands/history: rewrite with stdlib multi-errors#3626crazy-max merged 1 commit intodocker:masterfrom
crazy-max merged 1 commit intodocker:masterfrom
Conversation
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the commands/history rm error aggregation to use Go’s standard library multi-error support (errors.Join) and removes the now-unneeded HashiCorp multierror/errwrap dependencies from the vendored tree.
Changes:
- Replace
github.com/hashicorp/go-multierrorusage incommands/history/rm.gowitherrors.Join. - Remove
go-multierror/errwrapfromgo.modand vendor manifests, and delete their vendored sources. - Add a
depguardrule to prevent reintroducinggithub.com/hashicorp/go-multierror.
Reviewed changes
Copilot reviewed 3 out of 18 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| commands/history/rm.go | Switches multi-error aggregation to stdlib errors.Join. |
| go.mod | Removes direct/indirect requirements for go-multierror/errwrap. |
| go.sum | Updates module sums (partial) related to removed dependencies. |
| vendor/modules.txt | Removes vendored module entries for go-multierror/errwrap. |
| .golangci.yml | Adds depguard denial for github.com/hashicorp/go-multierror. |
| vendor/github.com/hashicorp/go-multierror/append.go | Deletes vendored go-multierror implementation. |
| vendor/github.com/hashicorp/go-multierror/flatten.go | Deletes vendored go-multierror implementation. |
| vendor/github.com/hashicorp/go-multierror/format.go | Deletes vendored go-multierror implementation. |
| vendor/github.com/hashicorp/go-multierror/group.go | Deletes vendored go-multierror implementation. |
| vendor/github.com/hashicorp/go-multierror/multierror.go | Deletes vendored go-multierror implementation. |
| vendor/github.com/hashicorp/go-multierror/prefix.go | Deletes vendored go-multierror implementation. |
| vendor/github.com/hashicorp/go-multierror/sort.go | Deletes vendored go-multierror implementation. |
| vendor/github.com/hashicorp/go-multierror/README.md | Removes vendored documentation for go-multierror. |
| vendor/github.com/hashicorp/go-multierror/Makefile | Removes vendored build tooling for go-multierror. |
| vendor/github.com/hashicorp/go-multierror/LICENSE | Removes vendored license file for go-multierror. |
| vendor/github.com/hashicorp/errwrap/errwrap.go | Deletes vendored errwrap implementation. |
| vendor/github.com/hashicorp/errwrap/README.md | Removes vendored documentation for errwrap. |
| vendor/github.com/hashicorp/errwrap/LICENSE | Removes vendored license file for errwrap. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
crazy-max
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.