util/ocilayout: replace regex for matching windows drive-letters#3825
Merged
crazy-max merged 1 commit intodocker:masterfrom May 4, 2026
Merged
util/ocilayout: replace regex for matching windows drive-letters#3825crazy-max merged 1 commit intodocker:masterfrom
crazy-max merged 1 commit intodocker:masterfrom
Conversation
follow-up to bf34a4c, which changed the isWindowsDrivePath function to use a regex for matching the trailing slash. This reverts it back to te previous implementation to avoid a regex, but adds a check for the colon to be followed by a forward-slash, which is faster, and avoids the overhead of `regex.MustCompile` during init. BenchmarkRegex-11 39056917 32.45 ns/op 0 B/op 0 allocs/op BenchmarkManual-11 1000000000 0.2476 ns/op 0 B/op 0 allocs/op Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
crazy-max
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
follow-up to bf34a4c, which changed the isWindowsDrivePath function to use a regex for matching the trailing slash.
This reverts it back to te previous implementation to avoid a regex, but adds a check for the colon to be followed by a forward-slash, which is faster, and avoids the overhead of
regex.MustCompileduring init.