rm: handle broken builders during removal#3934
Merged
Merged
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-rm-broken-builders
branch
from
bc9f7e6 to
22fcd6d
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-rm-broken-builders
branch
from
22fcd6d to
8db0221
Compare
tonistiigi
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2505
fixes #394
This makes
buildx rmable to remove broken builders when node loading is blocked by an invalid BuildKit config or an unreachable endpoint.The removal path now skips image config parsing when loading nodes for removal, including
--all-inactive, so a bad storedbuildkitd.tomlno longer prevents cleanup. The node cleanup path now attempts every node and returns the collected errors after cleanup, so one unavailable endpoint doesn't prevent another removable node from being removed.Removing a builder shouldn't require the builder to be healthy enough to build or inspect. The command still reports cleanup errors when a node cannot be reached, but it removes the builder metadata and cleans up any nodes that can be removed.