[v0.6] container-driver: fix volume destination for cache#752
Merged
tonistiigi merged 2 commits intodocker:v0.6from Aug 28, 2021
Merged
[v0.6] container-driver: fix volume destination for cache#752tonistiigi merged 2 commits intodocker:v0.6from
tonistiigi merged 2 commits intodocker:v0.6from
Conversation
The container-driver creates a Linux container (as there currently isn't a
Windows version of buildkitd). However, the defaults are platform specific.
Buildx was using the defaults from the buildkit `util/appdefault' package,
which resulted in Buildx running on a Windows client to create a Linux
container that used the Windows location, which causes it to fail:
invalid mount config for type "volume": invalid mount path: 'C:/ProgramData/buildkitd/.buildstate' mount path must be absolute
This patch hard-codes the destination to the default Linux path.
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 93867d0)
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com> (cherry picked from commit 9833420)
tonistiigi
force-pushed
the
v0.6-mount-path-fix
branch
from
94fe941 to
0b320fa
Compare
Member
|
ah! didn't realize we started a branch (thought we still did 0.6 from master) I should probably have a look if we need to get some of the docs changes into the branch (but that can wait) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick #751
The container-driver creates a Linux container (as there currently isn't a
Windows version of buildkitd). However, the defaults are platform specific.
Buildx was using the defaults from the buildkit `util/appdefault' package,
which resulted in Buildx running on a Windows client to create a Linux
container that used the Windows location, which causes it to fail:
This patch hard-codes the destination to the default Linux path.
Signed-off-by: Sebastiaan van Stijn github@gone.nl
(cherry picked from commit 93867d0)