bake: keep target inheritance#914
Merged
tonistiigi merged 1 commit intodocker:masterfrom Jan 14, 2022
Merged
Conversation
crazy-max
force-pushed
the
fix-target-inherit
branch
from
08a1b11 to
fafc066
Compare
tonistiigi
reviewed
Jan 12, 2022
crazy-max
force-pushed
the
fix-target-inherit
branch
from
fafc066 to
6887661
Compare
crazy-max
force-pushed
the
fix-target-inherit
branch
from
6887661 to
5bc002b
Compare
errordeveloper
approved these changes
Jan 12, 2022
Contributor
errordeveloper
left a comment
errordeveloper
left a comment
There was a problem hiding this comment.
just one minor nit, I think it'd help to improve readability :)
crazy-max
force-pushed
the
fix-target-inherit
branch
6 times, most recently
from
363d1e5 to
af84988
Compare
tonistiigi
reviewed
Jan 13, 2022
| func (c Config) target(name string, visited map[string]*Target, overrides map[string]map[string]Override) (*Target, error) { | ||
| if t, ok := visited[name]; ok { | ||
| return t, nil | ||
| } |
Member
There was a problem hiding this comment.
Need to block the key with nil value here. Otherwise, it goes to an infinite loop.
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
fix-target-inherit
branch
from
af84988 to
0044c28
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #912
After first pass inheritance is lost for the next targets in a group.
Signed-off-by: CrazyMax crazy-max@users.noreply.github.com