fix: rename cagent binary to docker-agent#109
Merged
derekmisler merged 1 commit intodocker:mainfrom Mar 23, 2026
Merged
Conversation
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
All changed code has been reviewed. No bugs found in the changes.
Summary:
- ✅ Binary download URLs correctly use
docker-agent-*naming (verified by PR author) - ✅ Workflow renaming is consistent across all files
- ✅ Version file renamed from
CAGENT_VERSIONtoDOCKER_AGENT_VERSION
This PR successfully renames cagent → docker-agent across the codebase with no functional issues.
Signed-off-by: Derek Misler <derek.misler@docker.com>
derekmisler
force-pushed
the
vk/5f3d-i-need-to-rename
branch
from
8f922c4 to
f3ddc2c
Compare
aheritier
approved these changes
Mar 23, 2026
derekmisler
added a commit
to derekmisler/cagent-action
that referenced
this pull request
Mar 24, 2026
The binary is installed as docker-agent (standalone), not as a docker CLI plugin. The command should be docker-agent, not docker agent. This was broken in docker#109 when the binary was renamed from cagent to docker-agent — the install step was updated but the invocation was changed to 'docker agent' (CLI plugin syntax) instead of 'docker-agent' (standalone binary syntax). Assisted-By: docker-agent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cagentbinary todocker-agentin download URLs, cache paths, and execution paths — the old asset names were dropped in v1.36.1CAGENT_VERSIONfile toDOCKER_AGENT_VERSIONand update all internal env vars/step IDsdocker agent) conventions in user-facing textdocker/cagent→docker/docker-agentrepo references in version update workflowDoes NOT rename the action itself, output names (
cagent-version), secret names, or<!-- cagent-review -->HTML markers — deferred to the full action rename.Test plan
test-output-extraction.sh,test-job-summary.sh,test-exploits.sh)https://github.com/docker/docker-agent/releases/download/v1.36.1/docker-agent-linux-amd64Closes docker/gordon#266