feat: fetch GitHub App credentials from AWS Secrets Manager via OIDC#119
Merged
derekmisler merged 1 commit intodocker:mainfrom Apr 14, 2026
Merged
Conversation
derekmisler
force-pushed
the
feat/oidc-secrets-manager
branch
from
f45ef15 to
d950f6c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
derekmisler
force-pushed
the
feat/oidc-secrets-manager
branch
3 times, most recently
from
d6d001e to
566b08a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
derekmisler
force-pushed
the
feat/oidc-secrets-manager
branch
3 times, most recently
from
5671b72 to
8bf8162
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
derekmisler
force-pushed
the
feat/oidc-secrets-manager
branch
15 times, most recently
from
0860a9c to
313e4e1
Compare
derekmisler
force-pushed
the
feat/oidc-secrets-manager
branch
6 times, most recently
from
8055b29 to
83abe3c
Compare
derekmisler
force-pushed
the
feat/oidc-secrets-manager
branch
2 times, most recently
from
b844483 to
e37f363
Compare
derekmisler
commented
Apr 14, 2026
| openai_api_key?: string; | ||
| } | ||
|
|
||
| export async function fetchAIApiKeys(credentials?: AwsCredentialIdentityProvider): Promise<void> { |
Contributor
Author
There was a problem hiding this comment.
It seems like a lot of "changed files" in this PR, but the alternative was to inline all of this JS in the yaml, so this seemed like the safer choice.
derekmisler
force-pushed
the
feat/oidc-secrets-manager
branch
from
e37f363 to
78f7208
Compare
derekmisler
commented
Apr 14, 2026
derekmisler
force-pushed
the
feat/oidc-secrets-manager
branch
from
78f7208 to
2b864d4
Compare
Signed-off-by: Derek Misler <derek.misler@docker.com>
derekmisler
force-pushed
the
feat/oidc-secrets-manager
branch
from
2b864d4 to
795d18f
Compare
trungutt
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: https://github.com/docker/gordon/issues/330
Depends on: https://github.com/docker/infra-terraform/pull/11303
Summary
Replaces the three org-level GitHub secrets (
CAGENT_REVIEWER_APP_ID,CAGENT_REVIEWER_APP_PRIVATE_KEY,CAGENT_ORG_MEMBERSHIP_TOKEN) with OIDC-based lookups from AWS Secrets Manager across all 5 reusable workflows, plusrelease.yml. Consumer repos no longer need those secrets configured — the only change they need is addingid-token: writeto their job permissions.This eliminates secret sprawl across ~50 consumer repos: credentials now live in one place (
docker-agent-action/github-appin Secrets Manager), so rotations happen once and propagate instantly.Infrastructure Status ✅
The companion Terraform PR (docker/infra-terraform#11303) has been applied:
arn:aws:iam::710015040892:role/docker-agent-action-20260409141318957000000001docker-agent-action/github-appsecret populated (app_id,private_key,org_membership_token)docker-agent-action/ai-api-keyssecret populated (anthropic_api_key,openai_api_key)Verified it works by testing it on dagent:
Tip
Comment
/reviewto trigger the PR Reviewer agent for automated feedback.Comment
/describeto generate a PR description.