use official github action for generating app token#121
Merged
derekmisler merged 1 commit intodocker:mainfrom Apr 1, 2026
Merged
Conversation
…:42] Signed-off-by: Derek Misler <derek.misler@docker.com>
Contributor
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR correctly migrates from the third-party tibdex/github-app-token action to the official actions/create-github-app-token@v3.0.0 action across all 9 workflow and composite action files. The parameter name changes (app_id → app-id, private_key → private-key) are applied consistently and correctly.
Security Review: The official GitHub action automatically masks generated tokens using GitHub Actions' built-in secret registration system, maintaining the same security posture as the previous third-party action.
No issues found in the changed code.
gtardif
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: https://github.com/docker/gordon/issues/355
Summary
Replaces the third-party
tibdex/github-app-tokenaction with the officialactions/create-github-app-tokenaction (v3.0.0) across all workflows and composite actions. This migration moves to a GitHub-maintained, first-party action for generating GitHub App tokens, improving supply-chain security and long-term supportability. The input parameter names also change from underscore-style (app_id,private_key) to kebab-case (app-id,private-key) to match the new action's interface.Tip
Comment
/reviewto trigger the PR Reviewer agent for automated feedback.Comment
/describeto generate a PR description.