Skip to content

use official github action for generating app token#121

Merged
derekmisler merged 1 commit intodocker:mainfrom
derekmisler:use-official-github-action-for-generating-app-toke
Apr 1, 2026
Merged

use official github action for generating app token#121
derekmisler merged 1 commit intodocker:mainfrom
derekmisler:use-official-github-action-for-generating-app-toke

Conversation

@derekmisler
Copy link
Copy Markdown
Contributor

@derekmisler derekmisler commented Apr 1, 2026

Related Issues

Closes: https://github.com/docker/gordon/issues/355

Summary

Replaces the third-party tibdex/github-app-token action with the official actions/create-github-app-token action (v3.0.0) across all workflows and composite actions. This migration moves to a GitHub-maintained, first-party action for generating GitHub App tokens, improving supply-chain security and long-term supportability. The input parameter names also change from underscore-style (app_id, private_key) to kebab-case (app-id, private-key) to match the new action's interface.


Tip

Comment /review to trigger the PR Reviewer agent for automated feedback.
Comment /describe to generate a PR description.

…:42]

Signed-off-by: Derek Misler <derek.misler@docker.com>
@derekmisler derekmisler self-assigned this Apr 1, 2026
@derekmisler derekmisler requested a review from a team April 1, 2026 16:10
@derekmisler derekmisler marked this pull request as ready for review April 1, 2026 16:10
@derekmisler derekmisler enabled auto-merge (squash) April 1, 2026 16:12
Copy link
Copy Markdown
Contributor

@docker-agent docker-agent bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR correctly migrates from the third-party tibdex/github-app-token action to the official actions/create-github-app-token@v3.0.0 action across all 9 workflow and composite action files. The parameter name changes (app_idapp-id, private_keyprivate-key) are applied consistently and correctly.

Security Review: The official GitHub action automatically masks generated tokens using GitHub Actions' built-in secret registration system, maintaining the same security posture as the previous third-party action.

No issues found in the changed code.

@derekmisler derekmisler merged commit d0b94dd into docker:main Apr 1, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants