Merged
Conversation
Signed-off-by: Derek Misler <derek.misler@docker.com>
aheritier
approved these changes
Apr 14, 2026
krissetto
reviewed
Apr 14, 2026
| with: | ||
| repository: docker/cagent-action | ||
| ref: ${{ github.workflow_sha }} | ||
| fetch-depth: 0 |
Contributor
Author
There was a problem hiding this comment.
because i need the tags for this step. fetch-depth: 1 doesn't fetch tags, unfortunately
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: https://github.com/docker/gordon/issues/383
Summary
Follow-up fixes after the OIDC migration. Addresses release workflow auth issues, adds backward-compatible deprecated secret inputs for callers still passing the old credentials, and fixes a JS scoping bug in the org-membership check.
Release workflow (
release.yml)fetch-depth: 0to checkout so version calculation has full git historyReusable review workflow (
review-pr.yml)CAGENT_ORG_MEMBERSHIP_TOKEN,CAGENT_REVIEWER_APP_ID, andCAGENT_REVIEWER_APP_PRIVATE_KEYas deprecated secret inputs — keeps callers from failing while they migrate to OIDCusernamevariable scoping: was declared asconstat the top then reassigned inside anif/else, which would throw at runtime. Now only assigned within each branchPR_AUTHORreference →process.env.PR_AUTHORSelf-review workflow (
self-review-pr.yml)uses:from a pinned SHA (docker/cagent-action/review-pr@f4853b...) to./review-prso the self-review workflow always tests against the local version of the actionTip
Comment
/reviewto trigger the PR Reviewer agent for automated feedback.Comment
/describeto generate a PR description.