update release to target all consumers, not just hash consumers#129
Merged
derekmisler merged 1 commit intodocker:mainfrom Apr 14, 2026
Conversation
Contributor
Author
|
/describe |
cd1a79f to
c217949
Compare
d51fd53 to
435a51c
Compare
Signed-off-by: Derek Misler <derek.misler@docker.com>
435a51c to
8918a7c
Compare
rumpl
approved these changes
Apr 14, 2026
trungutt
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: https://github.com/docker/gordon/issues/386
Summary
Fixes a critical bug where the release workflow pinned self-refs to a SHA that lacked compiled
dist/output, which would breaksetup-credentialsresolution for every consumer. Also broadens ref matching so consumers pinned by any format (not justSHA # v…) are correctly updated, and expands the pinning scope to cover all workflow files.Key changes
Release workflow (
.github/workflows/release.yml)dist/and createsTEMP_SHA; Pass 2 pins all self-refs toTEMP_SHAand createsRELEASE_SHAparented on it. Consumers resolving sub-actions now land on a commit wheredist/exists.@.*replaces the old@[a-f0-9]{40} # v…regex, catching any ref format (tag, branch, bare SHA).review-pr/,.github/workflows/,.github/actions/instead of 3 hardcoded files.dist/existence check before staging; stricter post-pin verification (exact@SHA # versionmatch, comment-line exclusion).Expression injection hardening (
action.yml,review-pr/action.yml,review-pr/reply/action.yml,review-pr.yml)run:scripts toenv:blocks.Dependency pinning (
package.json,pnpm-lock.yaml)^). Notable:@actions/core→ 3.0.0,vitest→ 4.0.18,typescript→ 5.9.3.Test fixes — Mocks updated for vitest 4.x ESM compatibility; rollup config suppresses harmless CJS/ESM interop warnings.
Tip
Comment
/reviewto trigger the PR Reviewer agent for automated feedback.Comment
/describeto generate a PR description.