Merged
Conversation
Signed-off-by: Derek Misler <derek.misler@docker.com>
aheritier
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: https://github.com/docker/gordon/issues/387
Summary
GitHub excludes the
workflowspermission from App installation tokens by default, even when the App itself has that permission granted. This PR explicitly passes all required permissions when requesting the installation token insrc/app-token.ts, ensuring the generated token includesworkflows: writealong with every other permission the App has.Permissions requested
actionscheckscontentsissuespull_requestsstatusesvariablesworkflowsmembersNote
Passing
permissionsexplicitly scopes the token down to only what's listed, so all App permissions must be included to avoid accidentally dropping any.Tip
Comment
/reviewto trigger the PR Reviewer agent for automated feedback.Comment
/describeto generate a PR description.