default GITHUB_TOKEN is taking precedence over the app's token#132
Merged
derekmisler merged 1 commit intodocker:mainfrom Apr 15, 2026
Conversation
Signed-off-by: Derek Misler <derek.misler@docker.com>
3508e32 to
6722af9
Compare
trungutt
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: https://github.com/docker/gordon/issues/391
Summary
When
actions/checkoutruns with its defaultpersist-credentials: true, it saves the built-inGITHUB_TOKENinto the local git config. This token takes precedence over the GitHub App token configured by the subsequent Setup credentials step, causing auth failures for operations that need the app's elevated permissions.This PR fixes the credential precedence issue in
release.yml, ensurestest.ymlbuilds the action before integration tests, and adds tooling for running workflows locally withact.Changes
.github/workflows/release.yml— addedpersist-credentials: falseto all fouractions/checkoutsteps (release, post-release-update, publish-release, major-publish jobs) so the defaultGITHUB_TOKENis not persisted in git config and the app token wins.github/workflows/test.yml— combined the install and build steps (pnpm install --frozen-lockfile && pnpm build) so the action is compiled before the integration test runsscripts/act-local.sh— new helper script for running workflows locally viaact; fetches GitHub App credentials from 1Password, generates an installation token via@octokit/auth-app, and passes them toactthrough a temp env file.actrc— configuresactdefaults (amd64 architecture,node:24-bookwormimage).gitignore— addedact-related temp files (.input,.secrets);.actrcis intentionally committedbiome.json— excluded.pnpm-storefrom linting/formattingTip
Comment
/reviewto trigger the PR Reviewer agent for automated feedback.Comment
/describeto generate a PR description.