follow-up to fix regex for finding consumer workflows#137
Merged
derekmisler merged 1 commit intodocker:mainfrom Apr 16, 2026
Merged
Conversation
Signed-off-by: Derek Misler <derek.misler@docker.com>
| --title "chore: update cagent-action to $VERSION" \ | ||
| --body "$PR_BODY" \ | ||
| --add-reviewer "derekmisler" | ||
| --add-reviewer "derekmisler" 2>&1 || echo "::warning::Failed to update PR #$EXISTING_PR in $REPO (may be non-fatal)" |
Contributor
There was a problem hiding this comment.
[MEDIUM] Overly broad error suppression silently drops PR title/body updates when reviewer assignment fails
The gh pr edit command combines three operations in a single call — --title, --body, and --add-reviewer — and the newly added 2>&1 || echo "::warning::..." guard is applied to the entire compound command. If --add-reviewer causes a failure (e.g., derekmisler is not a member of a consumer repo), both the title and body updates are also silently skipped, and the workflow continues with only a warning. Consumer PRs will retain stale titles/bodies from a previous release with no hard failure signal.
Suggested fix: Split the operations into two separate gh pr edit calls:
# This must succeed — update title and body unconditionally
gh pr edit "$EXISTING_PR" --repo "$REPO" \
--title "chore: update cagent-action to $VERSION" \
--body "$PR_BODY"
# Reviewer assignment may fail on external repos — tolerate it
gh pr edit "$EXISTING_PR" --repo "$REPO" \
--add-reviewer "derekmisler" 2>&1 || echo "::warning::Failed to add reviewer to PR #$EXISTING_PR in $REPO (may be non-fatal)"
trungutt
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: https://github.com/docker/gordon/issues/399
Summary
Two small fixes to the consumer-repo update job in the release workflow (
.github/workflows/release.yml):-sflag togit commitso automated version-bump commits include a DCO sign-off, matching the project's contribution requirements.gh pr editcall with2>&1 || echo "::warning::..."so a failure to update an existing PR (e.g., permissions, transient API error) emits a warning instead of failing the entire release job.Tip
Comment
/reviewto trigger the PR Reviewer agent for automated feedback.Comment
/describeto generate a PR description.