Skip to content

follow-up to fix regex for finding consumer workflows#137

Merged
derekmisler merged 1 commit intodocker:mainfrom
derekmisler:follow-up-to-fix-regex-for-finding-consumer-workfl
Apr 16, 2026
Merged

follow-up to fix regex for finding consumer workflows#137
derekmisler merged 1 commit intodocker:mainfrom
derekmisler:follow-up-to-fix-regex-for-finding-consumer-workfl

Conversation

@derekmisler
Copy link
Copy Markdown
Contributor

@derekmisler derekmisler commented Apr 16, 2026

Related Issues

Closes: https://github.com/docker/gordon/issues/399

Summary

Two small fixes to the consumer-repo update job in the release workflow (.github/workflows/release.yml):

  • Signed commits: Adds the -s flag to git commit so automated version-bump commits include a DCO sign-off, matching the project's contribution requirements.
  • Graceful PR edit failures: Wraps the gh pr edit call with 2>&1 || echo "::warning::..." so a failure to update an existing PR (e.g., permissions, transient API error) emits a warning instead of failing the entire release job.

Tip

Comment /review to trigger the PR Reviewer agent for automated feedback.
Comment /describe to generate a PR description.

Signed-off-by: Derek Misler <derek.misler@docker.com>
@derekmisler derekmisler self-assigned this Apr 16, 2026
@derekmisler derekmisler requested a review from a team April 16, 2026 20:23
@derekmisler derekmisler marked this pull request as ready for review April 16, 2026 20:23
@derekmisler derekmisler enabled auto-merge (squash) April 16, 2026 20:26
Copy link
Copy Markdown
Contributor

@docker-agent docker-agent Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟡 NEEDS ATTENTION

One medium-severity issue was confirmed in the changed code.

--title "chore: update cagent-action to $VERSION" \
--body "$PR_BODY" \
--add-reviewer "derekmisler"
--add-reviewer "derekmisler" 2>&1 || echo "::warning::Failed to update PR #$EXISTING_PR in $REPO (may be non-fatal)"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[MEDIUM] Overly broad error suppression silently drops PR title/body updates when reviewer assignment fails

The gh pr edit command combines three operations in a single call — --title, --body, and --add-reviewer — and the newly added 2>&1 || echo "::warning::..." guard is applied to the entire compound command. If --add-reviewer causes a failure (e.g., derekmisler is not a member of a consumer repo), both the title and body updates are also silently skipped, and the workflow continues with only a warning. Consumer PRs will retain stale titles/bodies from a previous release with no hard failure signal.

Suggested fix: Split the operations into two separate gh pr edit calls:

# This must succeed — update title and body unconditionally
gh pr edit "$EXISTING_PR" --repo "$REPO" \
  --title "chore: update cagent-action to $VERSION" \
  --body "$PR_BODY"
# Reviewer assignment may fail on external repos — tolerate it
gh pr edit "$EXISTING_PR" --repo "$REPO" \
  --add-reviewer "derekmisler" 2>&1 || echo "::warning::Failed to add reviewer to PR #$EXISTING_PR in $REPO (may be non-fatal)"

@derekmisler derekmisler merged commit 349161f into docker:main Apr 16, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants