Merged
Conversation
3318bee to
8e80d73
Compare
Signed-off-by: Derek Misler <derek.misler@docker.com>
8e80d73 to
e142517
Compare
rumpl
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes: https://github.com/docker/gordon/issues/403
Summary
Replaces all
git commit+git pushcalls with the GraphQLcreateCommitOnBranchmutation so every CI-generated commit is cryptographically signed by GitHub's web-flow GPG key. This prepares the repo for the org-wide mandatory commit signing rollout (May 4 target).What changed
New:
src/signed-commit.ts+src/signed-commit-cli.tsCore TypeScript module and CLI wrapper that create signed commits via the GraphQL
createCommitOnBranchmutation. Accepts file paths via--addflags or piped through--add-stdin. Supports--forcefor create-or-update branch semantics and--deletefor file removals. 14 unit tests insrc/__tests__/signed-commit.test.ts.release.yml— 3 commit points convertedgit commit-tree+git tag+git pushwith twocreateCommitOnBranchcalls on a staging branch, then API-based tag creation and staging branch cleanup.update-self-refsjob): Replacedgit checkout -B+git commit+git push --forcewith the CLI. Added pnpm/Node.js setup since this job didn't previously need a build step. File list passed between steps via/tmp/updated-files.txt.update-consumersjob): Replacedgit commit -s+git push --forcewith the CLI inside the existing loop. Added graceful error handling (|| { warning + continue }) for repos without write access.Configure gitstep (no moregit push).--headto allgh pr createcalls (local HEAD stays onmainwith API commits).update-docker-agent-version.yml— 1 commit point convertedReplaced
git checkout -B+git commit+git push --forcewith the CLI. Added pnpm/Node.js setup steps.rollup.config.mjsRefactored to multi-target build: setup-credentials + signed-commit-cli.
Housekeeping
**/dist/to.gitignoreandbiome.jsonexcludes.scripts/update-consumers.sh(dead code — the release workflow has its own inline implementation).Tip
Comment
/reviewto trigger the PR Reviewer agent for automated feedback.Comment
/describeto generate a PR description.