document is not defined#161
Merged
Merged
Conversation
derekmisler
force-pushed
the
document-is-not-defined
branch
from
8f7b1db to
023689e
Compare
Contributor
Author
|
/review |
derekmisler
force-pushed
the
document-is-not-defined
branch
from
023689e to
fac138e
Compare
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Assessment: 🔴 CRITICAL
This PR introduces a critical credential-flow bug that will cause every workflow using the new composite setup-credentials action to fail at runtime. One medium and one low finding also need attention. See inline comments for details.
derekmisler
force-pushed
the
document-is-not-defined
branch
from
fac138e to
5c5810c
Compare
Signed-off-by: Derek Misler <derek.misler@docker.com>
derekmisler
force-pushed
the
document-is-not-defined
branch
from
5c5810c to
6aab2fb
Compare
aheritier
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the "document is not defined" error in the GitHub Action by configuring Vite to use Node.js-compatible package variants. Also improves error handling for credential fetching and updates workflow dependencies.
Changes
resolve.conditionsto force Node.js exports (instead of browser variants) for packages like@aws-sdk/*, and disabledmodulePreloadpolyfill since this is a Node.js-only actioncore.infotocore.setFailedso the workflow properly fails when required credentials cannot be fetchedpnpm/action-setupto v6.0.5 andactions/setup-nodeto v6.4.0 across all workflowsTest plan
Closes: https://github.com/docker/gordon/issues/484