fix(review-pr): download artifact directly in reply-to-feedback to bypass secret masking

[docker-agent]

Problem

GitHub Actions' secret masking silently drops job outputs whose values resemble secrets. The comment-json output from the resolve-context job was being suppressed with the annotation:

Skip output 'comment-json' since it may contain secret.

This caused the reply-to-feedback job to always enter the else branch and fail with:

No comment data available

Failing run: https://github.com/docker/cagent-action/actions/runs/25337752257

Fix

Instead of relying on needs.resolve-context.outputs.comment-json (which is silently dropped), the reply-to-feedback job now downloads the pr-review-context artifact directly from inputs.trigger-run-id — the same artifact that was already successfully produced by the trigger workflow.

Changes in reply-to-feedback job

• Add actions: read permission — required for cross-run artifact download
• New Setup credentials step (first step, gated on trigger-run-id != '') — fetches GITHUB_APP_TOKEN via OIDC before the artifact download needs it
• New Download trigger context step — downloads pr-review-context artifact directly from the trigger run using actions/download-artifact@v8.0.1, bypassing job-output secret masking entirely
• Updated Parse comment context step — checks /tmp/context/comment.json first (new trigger path), then falls through to the direct event path; removes COMMENT_JSON/CTX_PR_NUMBER/CTX_PR_HEAD_SHA from the step's env block

Not changed

The resolve-context job and its comment-json output are unchanged for backward compatibility with any other callers.

The standalone reply-to-feedback.yml workflow is not touched — it already works correctly.

Testing

• actionlint: no errors
• YAML syntax: valid

[docker-agent]

Assessment: 🟡 NEEDS ATTENTION

The artifact-download approach correctly bypasses GitHub Actions' secret masking on job outputs. However, there is a logic inconsistency in the fallback handling.

1 NOTABLE finding (see inline comment).

[docker-agent]

Assessment: 🟡 NEEDS ATTENTION

Two medium findings and one low finding in the new steps added to reply-to-feedback. The core fix (artifact download bypassing secret masking) is correct and the step ordering is right.

[docker-agent]

All three review items addressed in 136d4f8:

F1 — Deleted the dead elif [ -n "$COMMENT_JSON" ] block. Since COMMENT_JSON, CTX_PR_NUMBER, and CTX_PR_HEAD_SHA were already removed from the step's env: block, the condition could never be true; the branch was unreachable dead code.

F2 — Added a hard-fail guard on pr_number.txt:

echo "pr-number=$(cat /tmp/context/pr_number.txt || { echo '::error::pr_number.txt missing from artifact'; exit 1; })" >> $GITHUB_OUTPUT

A missing file now surfaces a clear ::error:: annotation instead of silently writing an empty output.

F3 — Added a Verify token for cross-run artifact download step (gated on inputs.trigger-run-id != '') immediately after Setup credentials, matching the identical guard already present in the resolve-context job. Ensures OIDC/Secrets Manager misconfiguration fails early with a helpful error message rather than a cryptic download failure.

actionlint: clean ✅