feat: self-review uses local ./ action paths

[docker-agent]

Summary

Rewrites self-review-pr.yml so it no longer delegates to the reusable review-pr.yml workflow. Instead, the four jobs (resolve-context, review, reply-to-feedback, reply-to-mention) are inlined directly with ./ local paths for all docker/cagent-action action references.

This ensures self-review always exercises the action code on the current main branch rather than a pinned release SHA.

Changes

.github/workflows/self-review-pr.yml

• Removes the single uses: ./.github/workflows/review-pr.yml (workflow_call) delegation
• Inlines all four jobs verbatim from review-pr.yml, with these targeted changes:
  • Local paths replace all pinned docker/cagent-action/...@<SHA> references:

    Old (SHA-pinned)	New (local)
    docker/cagent-action/.github/actions/setup-credentials@<SHA>	./.github/actions/setup-credentials
    docker/cagent-action/review-pr@<SHA>	./review-pr
    docker/cagent-action/review-pr/reply@<SHA>	./review-pr/reply
    docker/cagent-action/review-pr/mention-reply@<SHA>	./review-pr/mention-reply
    docker/cagent-action/.github/actions/mention-reply@<SHA>	./.github/actions/mention-reply

  • Checkout step added as the first step of every job so the workspace is populated with main branch code before ./ paths are resolved
  • PR head checkout changed to path: pr-head in review and reply-to-feedback jobs so it does not overwrite the local action files
  • workflow_call inputs translated to event-context equivalents (e.g. inputs.trigger-run-id → github.event.workflow_run.id, step-level if: inputs.trigger-run-id != '' → if: github.event_name == 'workflow_run')
  • All third-party action SHAs (actions/checkout, actions/github-script, etc.) are preserved unchanged

.github/actions/mention-reply/action.yml

• Fix pre-existing node24 → node20 (AGENTS.md already documented the intent as node20; actionlint enforces valid runner names and node24 is not yet a valid value — this fix was required to make pnpm lint pass after local path resolution exposed the issue)

Validation

pnpm build && pnpm lint passes (Biome CI + tsc --noEmit + actionlint).

Refs: task to make self-review dogfood current-branch code.

[docker-agent]

Assessment: 🟡 NEEDS ATTENTION

Reviewed changes in .github/workflows/self-review-pr.yml and .github/actions/mention-reply/action.yml.

The node20 fix in mention-reply/action.yml is correct and matches project convention.

The workflow inlining is structurally sound: checkout ordering is correct (first step in every job), path: pr-head is used correctly for PR head checkouts, and inputs.* → github.event.* translations are correct.

2 NOTABLE findings (dead code from inlining — no runtime crash, but functional gaps).

[docker-agent]

Reverted in commit 30aa926: .github/actions/mention-reply/action.yml is back on node24.

The earlier node24 → node20 change was a mistake on my part. The root cause was that the locally-installed actionlint binary was v1.7.7, which didn't know about node24. The actual fix was to upgrade actionlint — v1.7.8 added node24 support (rhysd/actionlint#561). The CI lint job uses raven-actions/actionlint at latest which already ships v1.7.8+, so CI was never broken — only my local sandbox had an old binary. pnpm lint passes cleanly now with actionlint v1.7.12.

[derekmisler]

/review

[docker-agent]

Assessment: 🟢 APPROVE

All hypotheses were evaluated and dismissed:

• reply-to-feedback condition simplification: The omission of the direct pull_request_review_comment event path is correct — self-review-pr.yml has no such trigger, so the original dual-path condition from review-pr.yml would never have fired the direct branch anyway. The simplified condition is accurate for the available triggers.
• review job with always() + skipped resolve-context: GitHub Actions correctly handles skipped upstream jobs when always() is present. On issue_comment events, resolve-context is skipped and the review job evaluates its independent issue_comment branch — as intended.
• reply-to-mention on issue_comment events: The needs.resolve-context.result != 'failure' pattern is deliberately chosen to pass when resolve-context is skipped. All required event context for mention replies is directly available from the issue_comment payload without needing resolve-context.

The inlining of the four jobs from review-pr.yml into self-review-pr.yml with ./ local paths is correct. The PR head checkout to path: pr-head properly preserves the main-branch action files at the workspace root so that uses: ./review-pr resolves correctly. Event-context translations (inputs.trigger-run-id → github.event.workflow_run.id, etc.) are accurate.