Skip to content

self-review should just use the same setup as everything else#197

Merged
derekmisler merged 1 commit into
docker:mainfrom
derekmisler:self-review-should-just-use-the-same-setup-as-ever
May 8, 2026
Merged

self-review should just use the same setup as everything else#197
derekmisler merged 1 commit into
docker:mainfrom
derekmisler:self-review-should-just-use-the-same-setup-as-ever

Conversation

@derekmisler
Copy link
Copy Markdown
Contributor

@derekmisler derekmisler commented May 8, 2026

Summary

Simplify the self-review workflow by removing the complex cross-workflow artifact passing logic. The resolve-context job and its associated artifact handling are eliminated, and the review job now uses the same straightforward setup as other workflows in the repository.

Closes: https://github.com/docker/gordon/issues/560

Changes

  • Removed resolve-context job — eliminated 200+ lines of artifact download, parsing, and context resolution logic
  • Simplified review job — removed dependency on resolve-context outputs; now directly handles PR number resolution from event context
  • Removed workflow_dispatch trigger — no longer needed with simplified context handling
  • Updated workflow names — renamed "PR Review Trigger" to "Self PR Review - Trigger" for clarity
  • Added review_requested trigger — trigger workflow when a review is explicitly requested
  • Removed reply-to-feedback job — eliminated complex thread context building and artifact handling for reply logic

The workflow now uses the same event-driven approach as the rest of the codebase, reducing maintenance burden and improving reliability.

@derekmisler derekmisler self-assigned this May 8, 2026
@derekmisler derekmisler requested a review from a team May 8, 2026 14:12
@derekmisler derekmisler marked this pull request as ready for review May 8, 2026 14:12
Signed-off-by: Derek Misler <derek.misler@docker.com>
@derekmisler derekmisler force-pushed the self-review-should-just-use-the-same-setup-as-ever branch from 0595dd7 to 7bc8517 Compare May 8, 2026 14:56
@derekmisler derekmisler merged commit 6b07753 into docker:main May 8, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants