self-review should just use the same setup as everything else#197
Merged
derekmisler merged 1 commit intoMay 8, 2026
Conversation
Signed-off-by: Derek Misler <derek.misler@docker.com>
0595dd7 to
7bc8517
Compare
krissetto
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplify the self-review workflow by removing the complex cross-workflow artifact passing logic. The
resolve-contextjob and its associated artifact handling are eliminated, and thereviewjob now uses the same straightforward setup as other workflows in the repository.Closes: https://github.com/docker/gordon/issues/560
Changes
resolve-contextjob — eliminated 200+ lines of artifact download, parsing, and context resolution logicreviewjob — removed dependency onresolve-contextoutputs; now directly handles PR number resolution from event contextworkflow_dispatchtrigger — no longer needed with simplified context handlingreview_requestedtrigger — trigger workflow when a review is explicitly requestedreply-to-feedbackjob — eliminated complex thread context building and artifact handling for reply logicThe workflow now uses the same event-driven approach as the rest of the codebase, reducing maintenance burden and improving reliability.