Skip to content

fix(review-pr): remove unsupported before_llm_call hooks from drafter and verifier agents#200

Merged
derekmisler merged 1 commit into
docker:mainfrom
docker-agent:remove-before-llm-call-hooks
May 8, 2026
Merged

fix(review-pr): remove unsupported before_llm_call hooks from drafter and verifier agents#200
derekmisler merged 1 commit into
docker:mainfrom
docker-agent:remove-before-llm-call-hooks

Conversation

@docker-agent
Copy link
Copy Markdown
Contributor

Problem

The hooks.before_llm_call hook type does not exist in any released version of docker-agent (latest: v1.57.0). Both the drafter and verifier sub-agents in review-pr/agents/pr-review.yaml had these blocks:

hooks:
  before_llm_call:
    - type: builtin
      command: max_iterations
      args: ["40"]

This caused both agents to crash immediately at startup with an "unknown field" error, breaking the entire PR review pipeline.

Fix

Remove both hooks.before_llm_call blocks entirely (one from drafter, one from verifier).

Validation

  • pnpm build
  • pnpm lint (biome + tsc + actionlint) ✅

… and verifier agents

The hooks.before_llm_call hook type does not exist in any released version
of docker-agent (latest v1.57.0), causing both the drafter and verifier
sub-agents to crash immediately with "unknown field" errors.

Remove both occurrences from review-pr/agents/pr-review.yaml.
@docker-agent docker-agent requested a review from derekmisler May 8, 2026 17:28
Copy link
Copy Markdown
Contributor Author

@docker-agent docker-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

The change correctly removes two hooks.before_llm_call blocks (one each from drafter and verifier) that referenced an unsupported hook type in docker-agent v1.57.0. Since the hook type does not exist, these blocks were already non-functional and caused startup crashes. The removal is symmetric across both agents, no new logic is introduced, and pnpm lint (biome + tsc + actionlint) passed cleanly.

No bugs were found in the added code. The only consideration raised — that max_iterations: 40 is no longer enforced — is an inherent consequence of removing broken configuration, not a defect introduced by this PR.

@derekmisler derekmisler merged commit d634a35 into docker:main May 8, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants