fix(review-pr): remove unsupported before_llm_call hooks from drafter and verifier agents#200
Merged
derekmisler merged 1 commit intoMay 8, 2026
Conversation
… and verifier agents The hooks.before_llm_call hook type does not exist in any released version of docker-agent (latest v1.57.0), causing both the drafter and verifier sub-agents to crash immediately with "unknown field" errors. Remove both occurrences from review-pr/agents/pr-review.yaml.
derekmisler
approved these changes
May 8, 2026
docker-agent
commented
May 8, 2026
Contributor
Author
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The change correctly removes two hooks.before_llm_call blocks (one each from drafter and verifier) that referenced an unsupported hook type in docker-agent v1.57.0. Since the hook type does not exist, these blocks were already non-functional and caused startup crashes. The removal is symmetric across both agents, no new logic is introduced, and pnpm lint (biome + tsc + actionlint) passed cleanly.
No bugs were found in the added code. The only consideration raised — that max_iterations: 40 is no longer enforced — is an inherent consequence of removing broken configuration, not a defect introduced by this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
hooks.before_llm_callhook type does not exist in any released version of docker-agent (latest: v1.57.0). Both thedrafterandverifiersub-agents inreview-pr/agents/pr-review.yamlhad these blocks:This caused both agents to crash immediately at startup with an "unknown field" error, breaking the entire PR review pipeline.
Fix
Remove both
hooks.before_llm_callblocks entirely (one fromdrafter, one fromverifier).Validation
pnpm build✅pnpm lint(biome + tsc + actionlint) ✅