Skip to content

fix(review-pr): fix TIMEOUT_NOTE multi-line string breaking YAML block scalar#205

Merged
derekmisler merged 1 commit into
mainfrom
zampani/fix-timeout-note-yaml-indentation
May 12, 2026
Merged

fix(review-pr): fix TIMEOUT_NOTE multi-line string breaking YAML block scalar#205
derekmisler merged 1 commit into
mainfrom
zampani/fix-timeout-note-yaml-indentation

Conversation

@zampani-docker
Copy link
Copy Markdown
Contributor

Problem

review-pr/action.yml fails to load with:

(Line: 822, Col: 1): While parsing a block mapping, did not find expected key.

The TIMEOUT_NOTE assignment spans multiple lines where continuation lines start at column 0:

          TIMEOUT_NOTE="- **Exit code:** 124 (SIGKILL — 1800 s timeout)
- **Timeout limit:** 1800 s
- Verbose log artifact (${VERBOSE_LOG_FILE}) uploaded for debugging."

YAML terminates a run: | block scalar when a line's indentation drops below the established level. Lines 822–823 at column 0 cause the parser to exit the block scalar and treat - **Timeout limit:** as a top-level YAML sequence item, breaking action manifest loading.

Fix

Replace the multi-line string literal with $'\n' concatenation so all lines remain within the block scalar's indentation boundary. The string value is identical.

Impact

Introduced in v1.5.2, causes startup_failure for all consumers of review-pr. Verified: SHA 2f85a38b is broken; v1.5.1 (db555b0a) does not have this code path.

PR drafted by Claude Code.

…k scalar

The TIMEOUT_NOTE assignment spanned multiple lines where continuation
lines started at column 0. YAML terminates a run: | block scalar when
a line's indentation drops below the established level, causing the
runner to fail parsing action.yml with "did not find expected key".

Replace the multi-line string literal with $'\n' concatenation so all
lines stay within the block scalar's indentation boundary.

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
dvdksn added a commit to docker/docs that referenced this pull request May 12, 2026
v1.5.2's review-pr/action.yml has a YAML parse error at line 822 that
breaks the PR review workflow. Tracking upstream at
docker/cagent-action#205.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@derekmisler derekmisler merged commit 0a2adb5 into main May 12, 2026
12 checks passed
@derekmisler derekmisler deleted the zampani/fix-timeout-note-yaml-indentation branch May 12, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants