actually pass prompt-files through to the root action #36
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/describe |
|
✅ PR description has been generated and updated! |
derekmisler
force-pushed
the
actually-pass-prompt-files-through-to-the-root-act
branch
from
954f236 to
5d7c882
Compare
Contributor
Author
|
/review |
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
✅ No issues found!
This PR correctly implements the parameter propagation for add-prompt-files. The changes properly:
- Define the input parameter in the workflow with appropriate type and default value
- Pass it through both job flows (direct review and comment-triggered)
- Define it in the action inputs
- Forward it to the underlying cagent-action
All YAML syntax and GitHub Actions expressions are correct. The parameter chain is complete and consistent.
Great fix! 🚀
derekmisler
force-pushed
the
actually-pass-prompt-files-through-to-the-root-act
branch
from
5d7c882 to
357fb78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a missing parameter propagation issue where the
add-prompt-filesinput was defined in the root workflow but not being passed through to the underlyingreview-praction. This ensures that users can properly specify additional prompt files when triggering PR reviews.Changes
Fixed
add-prompt-filesparameter to both workflow job calls in.github/workflows/review-pr.ymladd-prompt-filesinput parameter toreview-pr/action.ymlaction definitionTechnical Details
This PR addresses a configuration gap where the workflow accepted an
add-prompt-filesinput parameter but failed to pass it through to the actual action that performs the review.Key changes:
.github/workflows/review-pr.yml: Addedadd-prompt-files: ${{ inputs.add-prompt-files }}to both thereview-pr-directandreview-pr-commentjob steps (lines 177 and 227)review-pr/action.yml: Added the missing input parameter definition foradd-prompt-fileswith proper description and default valueThe parameter allows users to specify comma-separated file paths (e.g., 'AGENTS.md,CLAUDE.md') that should be appended to the AI prompt during PR review, enabling more context-aware reviews.
Testing
add-prompt-filesparameterBreaking Changes
None - this is a bug fix that adds missing functionality without changing existing behavior.
Related Issues
None explicitly referenced - this appears to be a bug fix discovered during development.
Checklist