Skip to content

Don't enable thinking by default #1434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rumpl merged 1 commit into from
Jan 20, 2026
Merged

Don't enable thinking by default #1434

rumpl merged 1 commit into from
Jan 20, 2026

Conversation

@rumpl
Copy link
Member

@rumpl rumpl commented Jan 19, 2026

This should be explicitly set on the model config

@rumpl
Don't enable thinking by default
270de0a 
This should be explicitly set on the model config

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
@rumpl rumpl force-pushed the no-thinking-default branch from 4a104a0 to 270de0a Compare January 20, 2026 08:57
@rumpl rumpl marked this pull request as ready for review January 20, 2026 08:58
@rumpl rumpl requested a review from a team as a code owner January 20, 2026 08:58
@dgageot
Copy link
Member

dgageot commented Jan 20, 2026

I agree.
@krissetto, I like the idea of making it easy on users to use advanced features but I also found it verbose and not useful for most of my use cases.

@rumpl rumpl merged commit 63b9545 into docker:main Jan 20, 2026
5 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jan 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dgageot dgageot dgageot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rumpl @dgageot