Skip to content

Conversation

@stanislavHamara
Copy link
Contributor

image

@stanislavHamara stanislavHamara requested a review from a team as a code owner January 30, 2026 10:19
@krissetto
Copy link
Contributor

/review

@krissetto
Copy link
Contributor

The "Evaluation" line at the bottom of the dialog is a bit confusing IMHO, i wonder if we can make things clearer for the users

Also it'd be better if we used the scrollbar for ux consistency

github-actions[bot]
github-actions bot previously approved these changes Jan 30, 2026
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Approved - No issues found in the changed code.

This PR adds a permissions view dialog to display tool permission rules. The implementation is clean and follows existing code patterns:

  • Proper nil checks where needed (runtime checks, session checks)
  • Safe slice operations with boundary clamping in the scrolling logic
  • Consistent with existing codebase patterns
  • Appropriate separation of concerns between app, runtime, and UI layers

The code correctly:

  • Merges team and session-level permissions for display
  • Handles empty permission lists gracefully
  • Implements scrolling with proper bounds checking
  • Hides the command when no permissions are configured

Great work! 🚀

@stanislavHamara
Copy link
Contributor Author

The "Evaluation" line at the bottom of the dialog is a bit confusing IMHO, i wonder if we can make things clearer for the users

Also it'd be better if we used the scrollbar for ux consistency

The scrollbar is there, I guess the user can do both? 🤷

dgageot
dgageot previously approved these changes Jan 30, 2026
@krissetto
Copy link
Contributor

The scrollbar is there, I guess the user can do both?

oh, my bad. i got confused as i'm looking into other inconsistencies we have in dialogs and the up/down arrow threw me off :)

@dgageot dgageot merged commit 698aa6e into docker:main Jan 30, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants