-
Notifications
You must be signed in to change notification settings - Fork 228
Permissions view dialog #1534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Permissions view dialog #1534
Conversation
stanislavHamara
commented
Jan 30, 2026
|
/review |
|
The "Evaluation" line at the bottom of the dialog is a bit confusing IMHO, i wonder if we can make things clearer for the users Also it'd be better if we used the scrollbar for ux consistency |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
✅ Approved - No issues found in the changed code.
This PR adds a permissions view dialog to display tool permission rules. The implementation is clean and follows existing code patterns:
- Proper nil checks where needed (runtime checks, session checks)
- Safe slice operations with boundary clamping in the scrolling logic
- Consistent with existing codebase patterns
- Appropriate separation of concerns between app, runtime, and UI layers
The code correctly:
- Merges team and session-level permissions for display
- Handles empty permission lists gracefully
- Implements scrolling with proper bounds checking
- Hides the command when no permissions are configured
Great work! 🚀
The scrollbar is there, I guess the user can do both? 🤷 |
oh, my bad. i got confused as i'm looking into other inconsistencies we have in dialogs and the up/down arrow threw me off :) |
97d5575